From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Ben Greear <greearb@candelatech.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
"Kan Yan" <kyan@google.com>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [RFC 2/2] ath10k: reporting estimated tx airtime for fairness
Date: Fri, 28 Sep 2018 15:47:07 -0700 [thread overview]
Message-ID: <df1c4f9bde7682646c901305d1c0ab5d@codeaurora.org> (raw)
In-Reply-To: <25469b4a-219d-f941-15ad-a1c95308dd69@candelatech.com>
On 2018-09-28 12:57, Ben Greear wrote:
> On 09/28/2018 12:47 PM, Rajkumar Manoharan wrote:
>> On 2018-09-28 08:25, Toke Høiland-Jørgensen wrote:
>>
>>> So this just uses the calculated airtime based on rate and size?
>>> Wasn't
>>> there supposed to be an airtime usage value reported by the firmware?
>>> :)
>>>
>> Firmware interface changes are in progress. Airtime for sta/tid will
>> be reported via
>> htt tx-compl and rx ind messages. Meantime I thought it would be
>> useful to use Kan's changes
>> for ATF validation in ath10k using existing firmware. :)
>
> Maybe you can get the firmware guys to report the tx rate in the
> tx-completion
> (like I have been doing for years in my ath10k-ct firmware)? Then let
> the host
> do the air-time calculating?
>
> I'll give them firmware patches if the want :)
>
Ben,
As you know, it needs cleanup in firmware to free up space for new
interface
changes. Most of time we try to leverage rsvd/unused slots. I am aware
of that
you did a lot of clean up in CT firmware which is quite hard in official
firmware as it also has to support prop. releases. Kalle can answer much
better.
-Rajkumar
next prev parent reply other threads:[~2018-09-28 22:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 0:41 [RFC 1/2] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
2018-09-27 0:41 ` [RFC 2/2] ath10k: reporting estimated tx airtime for fairness Rajkumar Manoharan
2018-09-28 15:25 ` Toke Høiland-Jørgensen
2018-09-28 19:47 ` Rajkumar Manoharan
2018-09-28 19:57 ` Ben Greear
2018-09-28 22:47 ` Rajkumar Manoharan [this message]
2018-09-28 23:04 ` Ben Greear
2018-09-28 22:27 ` [RFC 1/2] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df1c4f9bde7682646c901305d1c0ab5d@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=kyan@google.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).