From: Ping-Ke Shih <pkshih@realtek.com>
To: Felix Fietkau <nbd@nbd.name>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 5/8] wifi: mt76: mt7996: use the correct vif link for scanning/roc
Date: Wed, 12 Mar 2025 02:08:51 +0000 [thread overview]
Message-ID: <df60cf260e2c4a15b9d43bd5bc29f562@realtek.com> (raw)
In-Reply-To: <20250311103646.43346-5-nbd@nbd.name>
> @@ -839,11 +840,18 @@ void mt7996_mac_write_txwi(struct mt7996_dev *dev, __le32 *txwi,
> bool beacon = !!(changed & (BSS_CHANGED_BEACON |
> BSS_CHANGED_BEACON_ENABLED)) && (!inband_disc);
>
> - mvif = vif ? (struct mt76_vif_link *)vif->drv_priv : NULL;
> - if (mvif) {
> - omac_idx = mvif->omac_idx;
> - wmm_idx = mvif->wmm_idx;
> - band_idx = mvif->band_idx;
> + if (vif) {
> + mvif = (struct mt7996_vif *)vif->drv_priv;
> + if (wcid->offchannel)
> + mlink = rcu_dereference(mvif->mt76.offchannel_link);
need a RCU read lock?
> + if (!mlink)
> + mlink = &mvif->deflink.mt76;
> + }
> +
> + if (mlink) {
> + omac_idx = mlink->omac_idx;
> + wmm_idx = mlink->wmm_idx;
> + band_idx = mlink->band_idx;
> }
>
> if (inband_disc) {
next prev parent reply other threads:[~2025-03-12 2:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 10:36 [PATCH 1/8] wifi: mt76: mt7996: revise TXS size Felix Fietkau
2025-03-11 10:36 ` [PATCH 2/8] wifi: mt76: mt7996: fix SER reset trigger on WED reset Felix Fietkau
2025-03-11 10:36 ` [PATCH 3/8] wifi: mt76: mt7996: remove unnecessary key->cipher check for BIP frames Felix Fietkau
2025-03-11 10:36 ` [PATCH 4/8] wifi: mt76: scan: set vif offchannel link for scanning/roc Felix Fietkau
2025-03-11 10:36 ` [PATCH 5/8] wifi: mt76: mt7996: use the correct vif " Felix Fietkau
2025-03-12 2:08 ` Ping-Ke Shih [this message]
2025-03-12 9:06 ` Felix Fietkau
2025-03-11 10:36 ` [PATCH 6/8] mt76: only mark tx-status-failed frames as ACKed on mt76x0/2 Felix Fietkau
2025-03-11 10:47 ` Felix Fietkau
2025-03-11 10:36 ` [PATCH 7/8] wifi: mt76: mt7996: implement driver specific get_txpower function Felix Fietkau
2025-03-11 13:55 ` Lorenzo Bianconi
2025-03-11 14:01 ` Felix Fietkau
2025-03-11 10:36 ` [PATCH 8/8] wifi: mt76: scan: fix setting tx_info fields Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df60cf260e2c4a15b9d43bd5bc29f562@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox