From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: RE: [PATCH v2 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware
Date: Mon, 9 Jan 2023 01:36:40 +0000 [thread overview]
Message-ID: <df9040d065214ce7a3f2f34506f97579@realtek.com> (raw)
In-Reply-To: <2aab4f3f-e914-4fe1-f29a-deac91774d05@gmail.com>
> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Sunday, January 8, 2023 11:07 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
> Subject: [PATCH v2 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware
>
> Or in the case of RTL8188EU, report the RSSI to the rate control code.
>
> The rate control code for RTL8188EU is less likely to switch to a lower
> rate when the RSSI is high. The firmware-based rate control in the other
> chips probably works the same way.
>
> This affects all the chips, but it was only tested with RTL8188EU,
> RTL8188FU, and RTL8192EU.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> v2:
> - Suggestion from Ping-Ke Shih:
> - Make h2c_size 4 instead of 3 in rtl8xxxu_gen1_report_rssi().
> Just to make it less confusing. It doesn't change the behaviour.
> ---
> .../net/wireless/realtek/rtl8xxxu/rtl8xxxu.h | 23 +++++++++++++
> .../realtek/rtl8xxxu/rtl8xxxu_8188e.c | 6 ++++
> .../realtek/rtl8xxxu/rtl8xxxu_8188f.c | 1 +
> .../realtek/rtl8xxxu/rtl8xxxu_8192c.c | 1 +
> .../realtek/rtl8xxxu/rtl8xxxu_8192e.c | 1 +
> .../realtek/rtl8xxxu/rtl8xxxu_8723a.c | 1 +
> .../realtek/rtl8xxxu/rtl8xxxu_8723b.c | 1 +
> .../wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 34 +++++++++++++++++++
> 8 files changed, 68 insertions(+)
>
[...]
next prev parent reply other threads:[~2023-01-09 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-08 15:06 [PATCH v2 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware Bitterblue Smith
2023-01-08 15:08 ` [PATCH v2 2/2] wifi: rtl8xxxu: Use a longer retry limit of 48 Bitterblue Smith
2023-01-09 1:36 ` Ping-Ke Shih
2023-01-09 1:36 ` Ping-Ke Shih [this message]
2023-01-16 16:27 ` [PATCH v2 1/2] wifi: rtl8xxxu: Report the RSSI to the firmware Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df9040d065214ce7a3f2f34506f97579@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).