Re: [PATCH wireless-next v2 07/16] wifi: cfg80211: add continuous ranging and PD request support

[Johannes Berg <johannes@sipsolutions.net>]

On Wed, 2026-03-04 at 12:45 +0530, Peddolla Harshavardhan Reddy wrote:
> 
> +++ b/net/wireless/pmsr.c
> @@ -91,11 +91,10 @@ static int pmsr_parse_ftm(struct cfg80211_registered_device *rdev,
>  			nla_get_u32(tb[NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST]);
>  
>  	if (capa->ftm.max_ftms_per_burst &&
> -	    (out->ftm.ftms_per_burst > capa->ftm.max_ftms_per_burst ||
> -	     out->ftm.ftms_per_burst == 0)) {
> +	    (out->ftm.ftms_per_burst > capa->ftm.max_ftms_per_burst)) {
>  		NL_SET_ERR_MSG_ATTR(info->extack,
>  				    tb[NL80211_PMSR_FTM_REQ_ATTR_FTMS_PER_BURST],
> -				    "FTM: FTMs per burst must be set lower than the device limit but non-zero");
> +				    "FTM: FTMs per burst must be set lower than the device limit");
>  		return -EINVAL;
>  	}

I really don't know anything about this protocol, but this also isn't
described in the commit message, and zero seems odd?

Maybe it should be allowed only under some additional conditions,
otherwise you're potentially changing some check that existing
drivers/devices rely on?

johannes