Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC V2 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries
Date: Fri, 28 Jun 2019 15:03:58 +0200	[thread overview]
Message-ID: <e293e8e7b38ba504eec40f396d21d3271c780a85.camel@sipsolutions.net> (raw)
In-Reply-To: <1561461027-10793-6-git-send-email-arend.vanspriel@broadcom.com>

On Tue, 2019-06-25 at 13:10 +0200, Arend van Spriel wrote:
> 
> +++ b/net/wireless/trace.h
> @@ -2446,10 +2446,11 @@
>  		       sizeof(int) * NUM_NL80211_BANDS);
>  	),
>  	TP_printk(WIPHY_PR_FMT ", " NETDEV_PR_FMT ", "
> -		  "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 60GHz=0x%x]",
> +		  "mcast_rates [2.4GHz=0x%x, 5.2GHz=0x%x, 6GHz=0x%x, 60GHz=0x%x]",
>  		  WIPHY_PR_ARG, NETDEV_PR_ARG,
>  		  __entry->mcast_rate[NL80211_BAND_2GHZ],
>  		  __entry->mcast_rate[NL80211_BAND_5GHZ],
> +		  __entry->mcast_rate[NL80211_BAND_6GHZ],
>  		  __entry->mcast_rate[NL80211_BAND_60GHZ])
>  );

This doesn't really - you just pointed out that legacy rates aren't
permitted, and so this bitmap doesn't make sense for 6 GHz?

johannes


  reply	other threads:[~2019-06-28 13:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25 11:10 [RFC V2 0/8] nl80211: add 6GHz band support Arend van Spriel
2019-06-25 11:10 ` [RFC V2 1/8] nl80211: add 6GHz band definition to enum nl80211_band Arend van Spriel
2019-06-25 11:10 ` [RFC V2 2/8] cfg80211: add 6GHz UNII band definitions Arend van Spriel
2019-06-25 11:10 ` [RFC V2 3/8] cfg80211: util: add 6GHz channel to freq conversion and vice versa Arend van Spriel
2019-06-25 11:10 ` [RFC V2 4/8] cfg80211: extend ieee80211_operating_class_to_band() for 6GHz Arend van Spriel
2019-06-25 11:10 ` [RFC V2 5/8] cfg80211: add 6GHz in code handling array with NUM_NL80211_BANDS entries Arend van Spriel
2019-06-28 13:03   ` Johannes Berg [this message]
2019-06-25 11:10 ` [RFC V2 6/8] cfg80211: use same IR permissive rules for 6GHz band Arend van Spriel
2019-06-25 11:10 ` [RFC V2 7/8] cfg80211: ibss: use 11a mandatory rates for 6GHz band operation Arend van Spriel
2019-06-28 13:04   ` Johannes Berg
2019-06-28 21:36     ` Igor Mitsyanko
2019-06-25 11:10 ` [RFC V2 8/8] cfg80211: apply same mandatory rate flags for 5GHz and 6GHz Arend van Spriel
2019-07-24  9:35 ` [RFC V2 0/8] nl80211: add 6GHz band support Johannes Berg
2019-07-24 13:40   ` Arend Van Spriel
2019-07-24 13:46     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e293e8e7b38ba504eec40f396d21d3271c780a85.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox