From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A70BEC388F7 for ; Fri, 13 Nov 2020 09:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43CA02145D for ; Fri, 13 Nov 2020 09:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726196AbgKMJKu (ORCPT ); Fri, 13 Nov 2020 04:10:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgKMJKr (ORCPT ); Fri, 13 Nov 2020 04:10:47 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23BC9C0613D1; Fri, 13 Nov 2020 01:10:47 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kdV6R-006r3z-RB; Fri, 13 Nov 2020 10:10:43 +0100 Message-ID: Subject: Re: [PATCH v2] mac80211: reject/clear user rate mask if not usable From: Johannes Berg To: Wen Gong Cc: Arend Van Spriel , linux-wireless@vger.kernel.org, kirtika@google.com, linux-wireless-owner@vger.kernel.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org Date: Fri, 13 Nov 2020 10:10:42 +0100 In-Reply-To: <6caaa87ba3f37bd424e92d03c2340689@codeaurora.org> References: <20170308132022.4216-1-johannes@sipsolutions.net> <07179008e9369bc81e152009ca85191d@codeaurora.org> <5decc452-7b2a-db1d-c5eb-04ab6bb61553@broadcom.com> <4b8f37fde23262547edb6ed4635cf89b@codeaurora.org> <83dd20def685d303106f285400367b6e@codeaurora.org> <798cea679ae1df5a2ab9b59dd81c8e2b3ca2d6e3.camel@sipsolutions.net> <30e2e578983e4df447e0c26c5bba0aba@codeaurora.org> <0e60e4cdc036a5ef7394848d212a6e3f499c386f.camel@sipsolutions.net> <256c487bb8c8c191a88d806e6125296e@codeaurora.org> <365b1abcfd043a3b0c356ec9f8c7c44acd5a79d2.camel@sipsolutions.net> <6caaa87ba3f37bd424e92d03c2340689@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2020-11-13 at 17:09 +0800, Wen Gong wrote: > On 2020-11-13 16:51, Johannes Berg wrote: > > On Fri, 2020-11-13 at 16:51 +0800, Wen Gong wrote: > > > > > yes. > > > It can add check with supp_rates[band] of ieee80211_sta for > > > NL80211_IFTYPE_STATION type. > > > for others, check with sdata->vif.bss_conf.basic_rates > > > > Right. > > > > Though, might need to check that only if there's no TDLS station or > > something? > > > yes, I think it should do like that for TDLS: > test_sta_flag(sta, WLAN_STA_TDLS_PEER) Yes but you have to iterate all the stations and check they belong to the interface and all that I think? johannes