From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Sascha Hauer <sha@pengutronix.de>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH 2/2] wifi: rtw88: Avoid using macid 0 in AP mode
Date: Mon, 29 Jul 2024 01:51:32 +0300 [thread overview]
Message-ID: <e4be0a75-43b2-4ae5-9aab-5c4a88e78097@gmail.com> (raw)
In-Reply-To: <9174a776-4771-4351-85fa-476e240d8ace@gmail.com>
In AP mode, the firmware stops transmitting beacons if it receives
H2C_CMD_RA_INFO for macid 0.
Leave macid 0 unused in AP mode. Macid 1 is already reserved for
broadcast/multicast. Assign macid 2 to the first connected client.
Tested with RTL8811CU and RTL8723DU.
Cc: stable@vger.kernel.org # 6.6.x
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
Tagging this for inclusion only in 6.6+ because that's the oldest
stable kernel with USB support, and presumably the PCI devices don't
have this problem. My RTL8822CE doesn't.
I don't know if SDIO devices also have this problem.
---
drivers/net/wireless/realtek/rtw88/main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index b3a089b4f707..e0b1ccc3759c 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -316,11 +316,12 @@ static void rtw_ips_work(struct work_struct *work)
mutex_unlock(&rtwdev->mutex);
}
-static u8 rtw_acquire_macid(struct rtw_dev *rtwdev)
+static u8 rtw_acquire_macid(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
{
unsigned long mac_id;
- mac_id = find_first_zero_bit(rtwdev->mac_id_map, RTW_MAX_MAC_ID_NUM);
+ mac_id = find_next_zero_bit(rtwdev->mac_id_map, RTW_MAX_MAC_ID_NUM,
+ vif->type == NL80211_IFTYPE_AP ? 2 : 0);
if (mac_id < RTW_MAX_MAC_ID_NUM)
set_bit(mac_id, rtwdev->mac_id_map);
@@ -345,7 +346,7 @@ int rtw_sta_add(struct rtw_dev *rtwdev, struct ieee80211_sta *sta,
struct rtw_vif *rtwvif = (struct rtw_vif *)vif->drv_priv;
int i;
- si->mac_id = rtw_acquire_macid(rtwdev);
+ si->mac_id = rtw_acquire_macid(rtwdev, vif);
if (si->mac_id >= RTW_MAX_MAC_ID_NUM)
return -ENOSPC;
--
2.45.2
next prev parent reply other threads:[~2024-07-28 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-28 22:49 [PATCH 1/2] wifi: rtw88: Fix USB devices not transmitting beacons Bitterblue Smith
2024-07-28 22:51 ` Bitterblue Smith [this message]
2024-07-30 6:33 ` [PATCH 2/2] wifi: rtw88: Avoid using macid 0 in AP mode Ping-Ke Shih
2024-07-30 12:55 ` Bitterblue Smith
2024-07-31 0:47 ` Ping-Ke Shih
2024-07-31 12:20 ` Bitterblue Smith
2024-08-08 9:38 ` Maciej S. Szmigiero
2024-08-19 2:59 ` Ping-Ke Shih
2024-08-19 21:20 ` Maciej S. Szmigiero
2024-08-20 0:34 ` Ping-Ke Shih
2024-08-20 23:15 ` Bitterblue Smith
2024-07-31 8:10 ` Ping-Ke Shih
2024-07-30 7:36 ` [PATCH 1/2] wifi: rtw88: Fix USB devices not transmitting beacons Ping-Ke Shih
2024-08-21 6:25 ` Ping-Ke Shih
2024-08-21 7:17 ` Michele Bisogno
2024-08-21 11:17 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4be0a75-43b2-4ae5-9aab-5c4a88e78097@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=pkshih@realtek.com \
--cc=sha@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).