Re: [RFT] brcmfmac: Fix structure size for WPA3 external SAE

James Prestwood
2025-02-12T14:25:28Z

Hi Keith,

On 2/12/25 6:13 AM, KeithG wrote:
> On Wed, Feb 12, 2025 at 7:42 AM James Prestwood <prestwoj@gmail.com> wrote:
>> Hi Arend,
>>
>> On 12/15/24 4:04 AM, Arend van Spriel wrote:
>>> From: Ting-Ying Li <tingying.li@cypress.com>
>>>
>>> Add pmkid parameter in "brcmf_auth_req_status_le" structure to
>>> align the buffer size defined in firmware "wl_auth_req_status"
>>> structure.
>>>
>>> Signed-off-by: Ting-Ying Li <tingying.li@infineon.com>
>>> [arend: adapted path to apply to per-vendor variant]
>>> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
>>> ---
>>> .../net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
>>> index 18129adb5dc2..1cbe66526d82 100644
>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
>>> @@ -54,6 +54,7 @@ struct brcmf_auth_req_status_le {
>>> u8 peer_mac[ETH_ALEN];
>>> __le32 ssid_len;
>>> u8 ssid[IEEE80211_MAX_SSID_LEN];
>>> + u8 pmkid[WLAN_PMKID_LEN];
>>> };
>>>
>>> /**
>>>
>>> base-commit: 1cac3bd863bef434d43e6b0554ac5d7f7f6350fe
>>> prerequisite-patch-id: d5b3eb93d54bd6a0508a91f4627ec3e59a810928
>>> prerequisite-patch-id: 653281e1349a038c7f48b3513243f3211fffab9e
>>> prerequisite-patch-id: 0e47ab711ef159237e20c860834d3ac269b05eb2
>> I've tested this and can also confirm it does fix external auth on
>> brcmfmac. I adapted it to work with the upstream 6.6 raspi kernel and
>> had no issues using IWD + external auth to connect to a WPA3 network. Is
>> this something that can be upstreamed?
>>
>> This is the firmware I'm using (no changes to the default raspi distro):
>>
>> Firmware: BCM4345/6 wl0: Aug 29 2023 01:47:08 version 7.45.265 (28bca26
>> CY) FWID 01-b677b91b
>>
>> Thanks,
>>
>> James
>>
> James,
>
> It is easy to do, but I am starting to get confused. Is this in
> addition to or instead of the patch you posted:
> [RFC] netdev: avoid PMKSA for fullmac drivers
This IWD patch is still needed. I'll poke Denis to merge this.
> Does it invalidate the need for using the latest cypress/infineon firmware:
> Firmware: BCM4345/6 wl0: Oct 28 2024 23:27:00 version 7.45.286
> (be70ab3 CY) FWID 01-95efe7fa
I guess? It just worked for me with this kernel patch and the firmware
that comes stock with raspbian. I haven't tried the latest cypress FW.
>
> If we can go to a default kernel and the 7.45.265 firmware, and still
> have wpa3, that would simplify things and make us happier.
Its not going to work with the default 6.6 kernel (or likely any
unpatched kernel). You definitely need the above kernel patch adding the
pmkid field.
>
> Keith