linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: RE: [PATCH v2 3/3] wifi: rtl8xxxu: Rename rtl8xxxu_8188f_channel_to_group
Date: Mon, 7 Nov 2022 06:52:40 +0000	[thread overview]
Message-ID: <e58b99d218e2494487114c65f3745e9d@realtek.com> (raw)
In-Reply-To: <ba8e3ea2-74f5-e1db-296e-4ae5f03084dc@gmail.com>



> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Sunday, November 6, 2022 6:55 AM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
> Subject: [PATCH v2 3/3] wifi: rtl8xxxu: Rename rtl8xxxu_8188f_channel_to_group
> 
> This name is an anomaly. Change it to rtl8188f_channel_to_group to
> follow the same pattern as the other functions.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> v2:
>  - No change.
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> index 4d044a8baa30..0f77312dd0ca 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> @@ -352,7 +352,7 @@ static int rtl8188fu_identify_chip(struct rtl8xxxu_priv *priv)
>  	return ret;
>  }
> 
> -static void rtl8xxxu_8188f_channel_to_group(int channel, int *group, int *cck_group)
> +static void rtl8188f_channel_to_group(int channel, int *group, int *cck_group)
>  {
>  	if (channel < 3)
>  		*group = 0;
> @@ -378,7 +378,7 @@ rtl8188f_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40)
>  	u8 cck, ofdmbase, mcsbase;
>  	int group, cck_group;
> 
> -	rtl8xxxu_8188f_channel_to_group(channel, &group, &cck_group);
> +	rtl8188f_channel_to_group(channel, &group, &cck_group);
> 
>  	cck = priv->cck_tx_power_index_A[cck_group];
> 
> --
> 2.38.0
> 
> ------Please consider the environment before printing this e-mail.

  reply	other threads:[~2022-11-07  6:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 22:53 [PATCH v2 1/3] wifi: rtl8xxxu: Move burst init to a function Bitterblue Smith
2022-11-05 22:54 ` [PATCH v2 2/3] wifi: rtl8xxxu: Split up rtl8xxxu_identify_chip Bitterblue Smith
2022-11-07  7:51   ` Ping-Ke Shih
2022-11-05 22:54 ` [PATCH v2 3/3] wifi: rtl8xxxu: Rename rtl8xxxu_8188f_channel_to_group Bitterblue Smith
2022-11-07  6:52   ` Ping-Ke Shih [this message]
2022-11-08 13:55   ` Jes Sorensen
2022-11-07  2:40 ` [PATCH v2 1/3] wifi: rtl8xxxu: Move burst init to a function Ping-Ke Shih
2022-11-07 15:50   ` Bitterblue Smith
2022-11-08 13:56   ` Jes Sorensen
2022-11-16  9:26 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e58b99d218e2494487114c65f3745e9d@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).