From: Masashi Honma <masashi.honma@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iw: Fix bitrate output when no rate info found
Date: Tue, 14 Feb 2017 18:35:51 +0900 [thread overview]
Message-ID: <e5c7bb68-73d9-48f1-3063-2617125ac14f@gmail.com> (raw)
In-Reply-To: <1487063659.4705.5.camel@sipsolutions.net>
On 2017-02-14 18:14, Johannes Berg wrote:
> Yes, this is bad! But if you saw that, why did you ever get to the
> below code that checked for the BITRATE(32) attributes?
>
>> So I used explaining message. We could see the message like this.
>>
>> tx bitrate: No rate info found!
>> rx bitrate: 48.0 MBit/s
>
> Yeah I was just thinking we could also see
>
> tx bitrate: (unknown)
>
> and then if there was MCS anyway you'd see
>
> tx bitrate: (unknown) MCS 7
>
> or something like that?
Yes, showing information as far as possible looks good.
I will modify this patch.
Masashi Honma.
next prev parent reply other threads:[~2017-02-14 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 5:21 [PATCH] iw: Fix bitrate output when no rate info found Masashi Honma
2017-02-14 5:26 ` Masashi Honma
2017-02-14 8:35 ` Johannes Berg
2017-02-14 8:55 ` Masashi Honma
2017-02-14 9:14 ` Johannes Berg
2017-02-14 9:35 ` Masashi Honma [this message]
2017-02-14 9:38 ` [PATCH v2] " Masashi Honma
2017-02-14 9:45 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c7bb68-73d9-48f1-3063-2617125ac14f@gmail.com \
--to=masashi.honma@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox