From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51F2236D4F9 for ; Mon, 9 Mar 2026 08:22:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773044580; cv=none; b=QU54sXDRijjgYHxUL1bO96HsRhObgHwbrJoYrZRCIpTMvGof3oIG8cOw7fv15XCC4KAyDF/P3kcsc3VSkhJViVbFzBitdbTUy11arYrurtHytClb8FKoIIFPNSumXb/YJTdEDkq/QI4u9Y4Q39L9cOrD86RL2sZWEGIVFhutlYU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773044580; c=relaxed/simple; bh=wc4KpAHHCOAr867bDpCKNjFxjoSaCDLT9gycb6oDdoc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Oknt+fMvMQgFQwfOFO7Uzb2DPPXgZ1yrS+pnyhZJY1rM/qCEAd5Nc+56FnwyGVwU214aNAJ70jR9BEp4k6IbcwdYSVleMW7E2t5cz6V76IeUegr+IPvoCmdsZbwy6wLG4oGWg6iIbgkOrnEC6Gj2ROv4KW5nFbjlWXa42W/rmFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=MjzRNFMp; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="MjzRNFMp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=wc4KpAHHCOAr867bDpCKNjFxjoSaCDLT9gycb6oDdoc=; t=1773044579; x=1774254179; b=MjzRNFMpWvPvIKviqEw+8HwQwZmHc7EDfLeJITMJMpdverM tq2qwrv0FocCGE3Kr6BtQG2JN28cB2y0Cum7pjj/uNnRoRw4AjmShXt3TspBm08eKTjHfFJznZg7l JcBFd2JdpOpTPdW/JFUgRxSEyxAFVHgCNInOKwzHTlInns6T8kcFqlYafRFQ6ldNNHZX5dp3upufH V7GaJahUQtNW2mGlYIaqjUDMrwMZM+QloNzsSGevd2z0U2UFJMeaTssmjfOwGh/O036rXhLiag6xk MvUbhXBvVPjalo1/uivSepR7G5+vVnv/t1nbUQWJQkjXvFBAr2aOpJ7S9oKq+row==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98.2) (envelope-from ) id 1vzVtA-0000000Co3i-3iBD; Mon, 09 Mar 2026 09:22:57 +0100 Message-ID: Subject: Re: [PATCH wireless-next] wifi: mac80211: Remove deleted sta links in ieee80211_ml_reconf_work() From: Johannes Berg To: Lorenzo Bianconi Cc: Lachlan Hodges , linux-wireless@vger.kernel.org Date: Mon, 09 Mar 2026 09:22:55 +0100 In-Reply-To: References: <20260307-mac80211-reconf-remove-sta-link-v1-1-efe58070cd36@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Mon, 2026-03-09 at 09:20 +0100, Lorenzo Bianconi wrote: > > Also, I think you need ieee80211_sta_remove_link() to tell the driver? >=20 > I think we already inform the driver running ieee80211_set_active_links()= so > ieee80211_sta_remove_link() seems redundant, right? >=20 > ieee80211_set_active_links() -> _ieee80211_set_active_links() -> drv_chan= ge_sta_links() Oh, hmm, yeah, good point! > > And I realized another thing - this needs to destroy TDLS stations that > > were on the link being removed, but maybe that's a separate commit. >=20 > Do you mean ieee80211_teardown_tdls_peers()? Is it done in > _ieee80211_set_active_links() too? So ... it was all already consistent all along, at least towards the driver? I totally missed that, sorry. Thanks for checking! johannes