* [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return
@ 2023-04-27 18:59 Martin Kaiser
2023-04-28 0:22 ` Ping-Ke Shih
2023-05-05 7:34 ` wifi: rtl8xxxu: rtl8xxxu_rx_complete(): " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Martin Kaiser @ 2023-04-27 18:59 UTC (permalink / raw)
To: Jes Sorensen, Kalle Valo, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: Martin Kaiser, linux-wireless, netdev, linux-kernel
Remove a return statement at the end of a void function.
This fixes a checkpatch warning.
WARNING: void function return statements are not generally useful
6206: FILE: ./drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:6206:
+ return;
+}
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index fd8c8c6d53d6..7e7bb11231e3 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -6281,7 +6281,6 @@ static void rtl8xxxu_rx_complete(struct urb *urb)
cleanup:
usb_free_urb(urb);
dev_kfree_skb(skb);
- return;
}
static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv,
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return
2023-04-27 18:59 [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return Martin Kaiser
@ 2023-04-28 0:22 ` Ping-Ke Shih
2023-05-05 7:34 ` wifi: rtl8xxxu: rtl8xxxu_rx_complete(): " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2023-04-28 0:22 UTC (permalink / raw)
To: Martin Kaiser, Jes Sorensen, Kalle Valo, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Martin Kaiser <martin@kaiser.cx>
> Sent: Friday, April 28, 2023 3:00 AM
> To: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>
> Cc: Martin Kaiser <martin@kaiser.cx>; linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return
>
> Remove a return statement at the end of a void function.
>
> This fixes a checkpatch warning.
>
> WARNING: void function return statements are not generally useful
> 6206: FILE: ./drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:6206:
> + return;
> +}
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index fd8c8c6d53d6..7e7bb11231e3 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -6281,7 +6281,6 @@ static void rtl8xxxu_rx_complete(struct urb *urb)
> cleanup:
> usb_free_urb(urb);
> dev_kfree_skb(skb);
> - return;
> }
>
> static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv,
> --
> 2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: rtl8xxxu: rtl8xxxu_rx_complete(): remove unnecessary return
2023-04-27 18:59 [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return Martin Kaiser
2023-04-28 0:22 ` Ping-Ke Shih
@ 2023-05-05 7:34 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-05-05 7:34 UTC (permalink / raw)
To: Martin Kaiser
Cc: Jes Sorensen, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Martin Kaiser, linux-wireless, netdev, linux-kernel
Martin Kaiser <martin@kaiser.cx> wrote:
> Remove a return statement at the end of a void function.
>
> This fixes a checkpatch warning.
>
> WARNING: void function return statements are not generally useful
> 6206: FILE: ./drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:6206:
> + return;
> +}
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
271a588d34ed wifi: rtl8xxxu: rtl8xxxu_rx_complete(): remove unnecessary return
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230427185936.923777-1-martin@kaiser.cx/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-05 7:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-27 18:59 [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return Martin Kaiser
2023-04-28 0:22 ` Ping-Ke Shih
2023-05-05 7:34 ` wifi: rtl8xxxu: rtl8xxxu_rx_complete(): " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).