From: Johannes Berg <johannes@sipsolutions.net>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3] wifi: cfg80211: check radio iface combination for multi radio per wiphy
Date: Wed, 11 Sep 2024 11:42:43 +0200 [thread overview]
Message-ID: <e77b379d48db796d199030ce904f8ed44ed679e5.camel@sipsolutions.net> (raw)
In-Reply-To: <20240904112928.2924508-1-quic_periyasa@quicinc.com>
On Wed, 2024-09-04 at 16:59 +0530, Karthikeyan Periyasamy wrote:
> Currently, wiphy_verify_combinations() fails for the multi-radio per wiphy
> due to the condition check on global interface combination that DFS only
> works on one channel.
As it should, really.
> In a multi-radio scenario, global interface
> combination encompasses the capabilities of all radio combinations, so it
> supports more than one channel with DFS.
No, that's not correct, it doesn't.
> For multi-radio per wiphy,
> interface combination verification needs to be performed for radio specific
> interface combinations.
Agree, but it shouldn't make an exception for DFS.
> This is necessary as the global interface
> combination combines the capabilities of all radio combinations.
No, it doesn't.
johannes
next prev parent reply other threads:[~2024-09-11 9:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 11:29 [PATCH v3] wifi: cfg80211: check radio iface combination for multi radio per wiphy Karthikeyan Periyasamy
2024-09-11 9:42 ` Johannes Berg [this message]
2024-09-11 12:51 ` Karthikeyan Periyasamy
2024-09-11 12:52 ` Johannes Berg
2024-09-11 13:15 ` Karthikeyan Periyasamy
2024-09-11 13:40 ` Johannes Berg
2024-09-11 15:21 ` Karthikeyan Periyasamy
2024-09-11 15:25 ` Johannes Berg
2024-09-11 15:58 ` Felix Fietkau
2024-09-11 16:00 ` Johannes Berg
2024-09-11 15:59 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e77b379d48db796d199030ce904f8ed44ed679e5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox