From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931F8326D65 for ; Tue, 28 Apr 2026 16:39:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394399; cv=none; b=hwCjCaae62hVp78VD0DMMPEIN4B5xOPKD9Jlgw5x/1b7mnP+CIcirjnqImYCqAZ8lzklupBXNF3v1Hfpj/Id808y2aHHM0mddWF+leHH0l+A3+BCLD7pIj/1olWXLEG8WB8MgBKErxrJGWEwIJWWSUwPVNkRql54cUs7wRFwFoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777394399; c=relaxed/simple; bh=qZzhuuormOf8Rul9WUs1IcMncFOwAXE+8P8hcP9siEk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V5X8Te9tlpHV7oMysRTS88Nbcq/805a5CxUPoL1XZNlxe7qCvOe75I4RQzNVYrURxjh/W0S2yjaVU6Gk3CzmlL2iccFupkcFR0i29/r0VE494TfUgflPSQRNMTjF8bHFBs5slqLKBCl4E4HCXe7g9fnnIbx6EVzppRbziFGN+5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=f7SzQjo2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PYkd7M3l; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="f7SzQjo2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PYkd7M3l" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63SFsCHi3634329 for ; Tue, 28 Apr 2026 16:39:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vS7MZwC/c/EdYfGyVktKa95cOMof7DSqpzppE9rq4aQ=; b=f7SzQjo2A6gvPSWl 4RSvhk1zwSXT5U1plZ2fJ5UTix3BYVLRUWvlmwud43vB0Z+JYf/OqNXL/5AbOrrG 8mTZis37OGV2svwSeXhojxzhKhDvnGF3b0NiEXfvTbiVqOxmmpWe0YZeJUfcimO2 n40R+UEiqXUZsBVkMiItGY+y6VBrQ/XMMw9sIwJ7f8R4Fx0xZhUcwQ9k0dURvFK0 GOw8air9IRe8GaiBlW3fY3MeOVtlGFz5MVK/HPDRUIrGLlxSkYc/7l2YnYrMRUU2 KF5YlhvY6ijYL26viLxaEbmRPQepuH9rTNJD1l7hW2aLWwIXa0ExsIIEXCCL58Lr gpo/pw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dty87rd3t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Apr 2026 16:39:57 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2e60238adb1so29393070eec.0 for ; Tue, 28 Apr 2026 09:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777394396; x=1777999196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vS7MZwC/c/EdYfGyVktKa95cOMof7DSqpzppE9rq4aQ=; b=PYkd7M3l2rol7qbMxfQktGLF9kkFmuNQpkXpinnffGbsC1qXZNJk7uSRfnxgQKPVfC rHq6CLx/9kkDCpOBNHoyu1q11eHWl9A2kVRampazY3cVLo1zowGy7HHGHAd4N4sbmJKX yquzHKnc/lYscara73DVETctt+Qq0J029iAplhnZ9jfIfE3GB8u3/4X1EmtvnrAPJQ4Y qPj7RjEph9ryUgsSAw+Ymu/t+fOPOMpFo1LewPm2fujRmtUfINf5bN34coUk/A5ubaFS TrjRy9vG4oxbYYtTa5uM42ArxgdWfC61tjcZQHDrz0b1W+wdwrOGWS2KPp29wFHwUP8M lVdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777394396; x=1777999196; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vS7MZwC/c/EdYfGyVktKa95cOMof7DSqpzppE9rq4aQ=; b=DVrJXhUDQzW76m3vjSzJtmMFcGydLXSSYdqTlWGAIHdnOsaDMxsFEn4NtWz+DzGo+d SIxrvRknLMiM2rN95fUe3Lw9dbt1igL7jmiDDXO5lqUTCGN3MbREROhOYzYPJ8S8lNlS jR4HMrh0JZ+hrse1/REJ395eJt8EciqR/Bj6BeNSrIVycQrj31VJFZ1/J1tX55aaehC3 u748yOPqxqC35+m92YYWL7tsFXPYOn8cOHLVUOoFLYiuqVoFtfljB5Lyracs7bpmPfVA 0lQXreNw3RbqOTA7tvaImk9bLyPxYTk1ZdgqUumSSa89p2+wS9Sux00kluLKAtV+dfwG +yOg== X-Forwarded-Encrypted: i=1; AFNElJ8BfWMnFOq1fGZfZx7TZN4KEyAehgeI0+j5e7sZw0agtI7AKM3n7CZ/AHQVWCF5zjL6h84D1hab6nTIFXhbGg==@vger.kernel.org X-Gm-Message-State: AOJu0YxPouGO9xhvO1+LriinC9MWMvpPKkr+QMiW+cx/+IVigHmFXOR/ V+Kum2zQW4rn3b2tcUMyIwyvaQBofobLezY/Vnvx4b7DKnImNCLNbEzFyxfyL8meJTUtFgoFhS7 iKZW0QAY6te7Lt6W7HmrXdAwzZJlRDvEbdtnQ6nkjlGrKouqbSuxeC14Ta9936RAR32t36A== X-Gm-Gg: AeBDies2vv1rXuxX9HlWd1ZYp0lCICr292hdE/jSX+RdjJPRSvsVvmbQGbn/CprAgy7 JFe5E6FnsriInz9EczLMjBzBUlY4OraElkAz+LwcCn2DKr/OJTsD+fXCHzPWAEHTesKvvUATJX4 YjosfhHwC4zDAVoHvKjdXDtN0uXUCqjUo8Ac8jdwsAU1IWb/WV6W0l1OuZxhKPUnLQTJTGOZgG0 oHgsIqeIJyqxVauWphbv+oj61Jvtlln/WkhnZoNiDTd/mG83rb7pPS9kr96dm8GX1YMGwLp8bx+ PsF8PLIyQIVEqfYRQ6vImgLP+VibLm96Ou5J6tsUlhhjwXBEH5gdh8IM+0okN0clUJOdG8Hc78E lzIeVv/US5DX65YSxNXx6gTuefK1FyfVvBl7LgR1UtSiGAyqq5CXsBlLUTIh8MKali+JGwTsSlU qnzRdtgJ+NZrZLB2lwIOV5spa6 X-Received: by 2002:a05:693c:3006:b0:2ea:3370:6e51 with SMTP id 5a478bee46e88-2ed09fb0d22mr1787697eec.4.1777394395799; Tue, 28 Apr 2026 09:39:55 -0700 (PDT) X-Received: by 2002:a05:693c:3006:b0:2ea:3370:6e51 with SMTP id 5a478bee46e88-2ed09fb0d22mr1787668eec.4.1777394395038; Tue, 28 Apr 2026 09:39:55 -0700 (PDT) Received: from [192.168.1.47] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed0a0ce878sm2622054eec.16.2026.04.28.09.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 09:39:54 -0700 (PDT) Message-ID: Date: Tue, 28 Apr 2026 09:39:51 -0700 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] wifi: ath: Use the unified QMI service ID instead of defining it locally To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org, Dmitry Baryshkov References: <20260316171419.2619620-1-daniel.lezcano@oss.qualcomm.com> <20260316171419.2619620-3-daniel.lezcano@oss.qualcomm.com> <51e28a7f-8362-4bf1-9b9a-9af9cda1d748@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <51e28a7f-8362-4bf1-9b9a-9af9cda1d748@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=abJRWxot c=1 sm=1 tr=0 ts=69f0e2dd cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=yneryZK0HH5dXzgVxAEA:9 a=QEXdDO2ut3YA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-GUID: zjyKyuv-zDTm-t_30YAU0PMAZ7zOm9QJ X-Proofpoint-ORIG-GUID: zjyKyuv-zDTm-t_30YAU0PMAZ7zOm9QJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI4MDE2MCBTYWx0ZWRfX12fwxg4JeHAn yuZ2YDoQhMGw63fiT+SNnMc9JUyHJtyTlJTddyC2YZu0fy5IMJG4LYi4ma8fMVmpscG31LULidY ZskZRogiU/CZey8RbEUlupxBDmGZpR7VfWzhPJYbTNwN6z6FIiM/axaiLnLcsUcfJkEFgFUbNSX 7xAIF+3WRHaDZ8lVH37Xi8WBAP7Oo7BofEEVTwS/i61ouda5nzUjeeJvdWdLZL5SRn6n4kPn52Z VL1g6QEg1ZCj2QoGL5fXygCByOFRF8/W273Jl/aGyVkMqx/e5TjbuqNMLZyiqTvvn8uyU7WYFvQ 7TNhzF8ft1E2iAfKPcTN6eqLG2E1Tm4sfcJTDBIFnDahw4+sTXd1eBzK2XKO3IpQs/Cc5KvvjKR 4YwZFjiQO0kci8nettwy31wUwq9EA36pgxdcbR/99cX8dpTpjagyz3bvdwNIZHtNUn7yZpjjxL+ LurmO13ZT1M4hbARURA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-28_05,2026-04-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604280160 On 3/19/2026 7:26 AM, Jeff Johnson wrote: > On 3/16/2026 10:14 AM, Daniel Lezcano wrote: >> Instead of defining a local macro with a custom name for the QMI >> service identifier, use the one provided in qmi.h and remove the >> locally defined macro. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Daniel Lezcano > > Bjorn, > Feel free to take this through your tree since I don't think it will conflict > with anything in mine and it will take time for the definition to propagate > back to my tree via the normal workflow (which I would prefer over merging the > immutable branch). > > Acked-by: Jeff Johnson Now NAK... The definitions have now propagated back to my tree, so I'll now take this patch through my tree. /jeff