From: Ping-Ke Shih <pkshih@realtek.com>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next] Revert "wifi: rtw88: add WQ_UNBOUND to alloc_workqueue users"
Date: Wed, 10 Dec 2025 00:17:36 +0000 [thread overview]
Message-ID: <eaef2ed2c7814a5a8fcbea90cce88ea8@realtek.com> (raw)
In-Reply-To: <CAAofZF4Z=O=q96RaTUKFpXiLGEYU84JB+oqfWtTc2njHGgC2Ww@mail.gmail.com>
Marco Crivellari <marco.crivellari@suse.com> wrote:
> Sent: Tuesday, December 9, 2025 5:57 PM
> rtw89On Mon, Dec 8, 2025 at 1:40 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
> > Hi Marco,
> >
> > Will you send a patch to point out WQ_PERCPU explicitly?
> >
> > > + rtwusb->rxwq = alloc_workqueue("rtw88_usb: rx wq", WQ_BH, 0);
> > > if (!rtwusb->rxwq) {
> > > rtw_err(rtwdev, "failed to create RX work queue\n");
> > > return -ENOMEM;
>
> Hi,
>
> The v1 is indeed correct, sorry for that: WQ_BH should be per-cpu
> because it is executed in softirq context.
>
> Should I send a patch prefixed with [BUG] in order to fix it or the v1
> could be used and we're ok?
I think v1 is ok, so I re-open v1 [1], and plan to merge this in -next cycle.
[1] https://patchwork.kernel.org/project/linux-wireless/patch/20251113160605.381777-3-marco.crivellari@suse.com/
>
> I noticed also in 6.18 "rtw89_usb_init_rx" is allocating a workqueue
> and is missing WQ_PERCPU.
Please prepare another patch for this.
next prev parent reply other threads:[~2025-12-10 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 18:32 [PATCH rtw-next] Revert "wifi: rtw88: add WQ_UNBOUND to alloc_workqueue users" Bitterblue Smith
2025-12-08 0:40 ` Ping-Ke Shih
2025-12-08 1:42 ` Zenm Chen
2025-12-08 2:11 ` Ping-Ke Shih
2025-12-08 3:20 ` Zenm Chen
2025-12-08 3:46 ` Ping-Ke Shih
2025-12-09 9:56 ` Marco Crivellari
2025-12-10 0:17 ` Ping-Ke Shih [this message]
2025-12-10 9:58 ` Marco Crivellari
2025-12-15 8:49 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaef2ed2c7814a5a8fcbea90cce88ea8@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox