From: Johannes Berg <johannes@sipsolutions.net>
To: Sarika Sharma <sarika.sharma@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next 1/2] wifi: cfg80211/mac80211: change memory allocation for link_sinfo structure
Date: Wed, 29 Apr 2026 08:16:53 +0200 [thread overview]
Message-ID: <eb8474cd25dd12541557afecf3434e58a69a322b.camel@sipsolutions.net> (raw)
In-Reply-To: <3945df66-0f90-4371-a85d-26cd220dfc56@oss.qualcomm.com>
On Wed, 2026-04-29 at 11:38 +0530, Sarika Sharma wrote:
>
> On 28-04-2026 15:01, Johannes Berg wrote:
> > On Tue, 2026-04-28 at 14:39 +0530, Sarika Sharma wrote:
> > >
> > > +int cfg80211_alloc_link_sinfo_stats(struct link_station_info **link_sinfo,
> >
> > really?
> >
> > johannes
>
> So, this helper API I introduced in cfg80211 since struct
> link_station_info is defined and primarily used
> there. Keeping allocation and lifetime management in cfg80211 ensures
> consistent ownership and cleanup once the link_station_info is consumed.
>
> Please let me know if I understood your concern correctly, or if you
> were referring to something else in this patch.
Hah, right. I was merely thinking of returning an error and using a
double-pointer for assignment. There are better ways of doing that.
johannes
next prev parent reply other threads:[~2026-04-29 6:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 9:09 [PATCH wireless-next 0/2] wifi: cfg80211/mac80211: optimize station info handling Sarika Sharma
2026-04-28 9:09 ` [PATCH wireless-next 1/2] wifi: cfg80211/mac80211: change memory allocation for link_sinfo structure Sarika Sharma
2026-04-28 9:31 ` Johannes Berg
2026-04-29 6:08 ` Sarika Sharma
2026-04-29 6:16 ` Johannes Berg [this message]
2026-04-29 7:24 ` Sarika Sharma
2026-04-28 9:09 ` [PATCH wireless-next 2/2] wifi: cfg80211/mac80211: set only non-MLO-applicable fields for non-MLO stations Sarika Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb8474cd25dd12541557afecf3434e58a69a322b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=sarika.sharma@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox