From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Kang Yang <kang.yang@oss.qualcomm.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result
Date: Mon, 26 Oct 2026 13:56:38 +0800 [thread overview]
Message-ID: <ec616beb-0423-4b0c-b0bd-71a00aad6977@oss.qualcomm.com> (raw)
In-Reply-To: <20261015-hal_rx_mon_status-v1-1-b32d5a7383fd@oss.qualcomm.com>
On 10/16/2026 1:49 PM, Kang Yang wrote:
> ath12k_wifi7_dp_mon_parse_rx_dest() returns enum
> hal_rx_mon_status, but one caller still checks the result against
> HAL_TLV_STATUS_PPDU_DONE.
>
> Use HAL_RX_MON_STATUS_PPDU_DONE instead. This is a cleanup only
> since both values are identical.
>
> Remove the now unused HAL_TLV_STATUS_* defines.
>
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
>
> Signed-off-by: Kang Yang <kang.yang@oss.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c | 2 +-
> drivers/net/wireless/ath/ath12k/wifi7/hal_rx.h | 5 -----
> 2 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> index 1e29c13ad66d..7d29b49e8a54 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi7/dp_mon.c
> @@ -3214,7 +3214,7 @@ __ath12k_wifi7_dp_mon_process_ring(struct ath12k *ar, int mac_id,
>
> hal_status = ath12k_wifi7_dp_mon_parse_rx_dest(&ar->dp, pmon, skb);
>
> - if (hal_status == HAL_TLV_STATUS_PPDU_DONE) {
> + if (hal_status == HAL_RX_MON_STATUS_PPDU_DONE) {
Not part of this diff, but the same topic:
ath12k_wifi7_dp_mon_srng_process() still declares "u32 hal_status" and
stores the enum hal_rx_mon_status returned by
ath12k_wifi7_dp_mon_rx_parse_mon_status() in it. If you respin for any
reason, better to have it fixed as well.
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
next prev parent reply other threads:[~2026-10-26 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 5:49 [PATCH ath-next] wifi: ath12k: use hal_rx_mon_status for PPDU parse result Kang Yang
2026-10-26 5:56 ` Baochen Qiang [this message]
2026-10-26 6:00 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec616beb-0423-4b0c-b0bd-71a00aad6977@oss.qualcomm.com \
--to=baochen.qiang@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=kang.yang@oss.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox