From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 761A7148FF6 for ; Wed, 3 Apr 2024 14:02:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712152960; cv=none; b=ILwJekwSjSnzu0Zvq9vNKhPKGC5grKHK8swQ6zxDKMPKzWCQ4D3EhhmLSLrhlg8cmtR6gMdqCfBPEEpIgD4T1MwitEYk4ejkgNM9vekZJWsI90HJAP8jIE5xksa5JZyb/fZspTqB2jQmumh1OlIzYnZO+4xjtkFQkZvqZCF8QME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712152960; c=relaxed/simple; bh=UXsMLWolQ65sgQY9ytl3MN9D3SzJEncq+W8keY+wzwk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZ1IL5EmNDN4EoM8vNBBdk23ncdJofl1VM6xicwZrDsQYXEn1yF7VCmjl0gF+MyLH43R8yRyDs2/7YfSG8GB8LUvlNe+GY4VoChvzUMDNTBQYRSHWULqEqx7UXGdzLM5an8WGZcAI4Pu9zoT6B/fFU+0dXfX6lJgjeBo0BLKibE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yq2046sf; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yq2046sf" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2d82713f473so39699291fa.3 for ; Wed, 03 Apr 2024 07:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712152956; x=1712757756; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Xffq3xDlhcth/zmXxLFozcKGPrlUpFFerV06UWS3/eA=; b=yq2046sfhd0j1mkC1QM6GiS2anJPLRSS7PD2n8fg9RdHi+odltz9AZqUXjN6Q0Ntwz s+3IegMvpK18U0IU5vHL5MywXr5bBz803LsNpsbCrzYhjBoYQL37uO1uP0CwIGOGhedQ nUrPIcojdELYUiLxuSEOHmgCUj4PONGZij3hRwVPS8TFesH/6dVJ0f6oqgHyo2NzRjoY /jny9N+oFKF2/f9PvFvgxuWFBgI70UosDgs3MGwx8/FcPgUEmdU+tB4k+hu0ELJD2+eF hNM9Qu3aTR2deYqAaxINpaYcjsNVxR3mTh7vjFjsIf+48hJeePH4kFaUS/f9qAX/X3zo DZvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712152956; x=1712757756; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xffq3xDlhcth/zmXxLFozcKGPrlUpFFerV06UWS3/eA=; b=Lcw1ptIw/Fkaje11baZUkGvXH9kGlvYIuR+hLVTAUhJ0n38Ce9XFHkS0HtUFeHUJJ2 vuynL3ZxHHHp3mH6wTjJRlC9Kk7bTI9tFDMyh32ZLaJRRJN4m34G5EbnTXvDE24dNPik wtBuqweDoXGNGT6GHuEp50Zj8wrZA5qj1KMYCw7kpEqDoGDaH5JeQtsRc0iQZzhsYOQQ lXK9UHoC0lGRZ0nME6qgTFTA02QzIavyIgbDAZvHmNdarcc8fE+gX3CWFj4ZgQkbv3uW //KbD/IogsD1Q1IM3wxmZPEWtfsTbgtdznyKQpOWnzESDpCsCANVVJ8wp92qnH/p2u45 pyhQ== X-Forwarded-Encrypted: i=1; AJvYcCW3keFOXgoXh7EjaFKKW9gAV5MSVLmiANDiONiJXUW2RgmTgIuGn528ZkpmZWmfd+SWx4kssoTYfL0LVJdv0ucI8UGOxkGlVrs1Pmu8mmo= X-Gm-Message-State: AOJu0Yz/R6M0Ud+6wGPtt42RfECoWpkVeaBZzG8X64B75jhzh9rLF/oo NuULkr7WoSIV/mIL3eeTevYYLGbSt+5PhYKoFkHST9V7D0Ze13E/J/ClZK5toX0= X-Google-Smtp-Source: AGHT+IETrJrTqm00Dp9BwZahe/RD7sPBnfDU3orBH0Q5JhIG1nu10mWk/AhrLzD3NxyRT2xEBRwUmQ== X-Received: by 2002:a2e:8550:0:b0:2d4:3e96:47ee with SMTP id u16-20020a2e8550000000b002d43e9647eemr3625858ljj.26.1712152956372; Wed, 03 Apr 2024 07:02:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id o1-20020a1709064f8100b00a46baba1a0asm7788206eju.100.2024.04.03.07.02.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 07:02:33 -0700 (PDT) Message-ID: Date: Wed, 3 Apr 2024 16:02:30 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] wifi: ath10k: sdio: simplify module initialization To: Kalle Valo , Jeff Johnson Cc: Jeff Johnson , Brian Norris , Ajay Singh , Claudiu Beznea , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240329171019.63836-1-krzysztof.kozlowski@linaro.org> <87jzle5zda.fsf@kernel.org> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <87jzle5zda.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/04/2024 15:50, Kalle Valo wrote: > Jeff Johnson writes: > >> On 3/29/2024 10:10 AM, Krzysztof Kozlowski wrote: >>> This driver's initialization functions do not perform any custom code, >>> except printing messages. Printing messages on modules >>> loading/unloading is discouraged because it pollutes the dmesg >>> regardless whether user actually has this device. Core kernel code >>> already gives tools to investigate whether module was loaded or not. >>> >>> Drop the printing messages which allows to replace open-coded >>> module_sdio_driver(). >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> Acked-by: Jeff Johnson >> >>> >>> --- >>> >>> FYI: >>> I have ongoing patchset touching few lines above this patch chunk >>> (sdio_driver) which might go via different tree. If that patchset is >>> applied via different tree, it might result in a trivial conflict, but >>> there is no dependency. They can go via separate trees (except that >>> trivial conflict). >> >> I'll let Kalle respond if he'll take this through the ath tree vs letting you >> take it through your tree > > I prefer to avoid conflicts as much as possible. In this patchset I'm > not anticipating any conflicts with wireless trees, so if we can avoid > any conflicts, please take this patchset via the other tree: > > Acked-by: Kalle Valo > > I'll drop this patchset from my queue. But if I should take these to > wireless trees instead just let me know. Just to clarify - only the first patch has possible conflict. The rest should be fine. Can you pick up 2-6 patches from this set? Best regards, Krzysztof