From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B6CAC3A59B for ; Fri, 30 Aug 2019 18:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3029223429 for ; Fri, 30 Aug 2019 18:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FpT+fCHq"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FpT+fCHq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727940AbfH3SDj (ORCPT ); Fri, 30 Aug 2019 14:03:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60286 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727246AbfH3SDi (ORCPT ); Fri, 30 Aug 2019 14:03:38 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D996960271; Fri, 30 Aug 2019 18:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567188217; bh=u51vqjZVqUScCC6bYAfBMXmDteHGhmwlt1+QHL33A+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FpT+fCHqLdmsyKUilTlW/XAdwcVFyIm9VMYmnENF/OKCoapqUrp8vYx8Bh3APSdQa 5m8zziq56Eeo1Upq9FZ3XOpnpkfcT6XJj58ODTfz5eDH8H0c73d7YxcWT/lT4XtsoF HdWlg7GdCZ+CUQUA0LFIzi5vDYSRTU7znIJVEC8M= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 4E64A60159; Fri, 30 Aug 2019 18:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1567188217; bh=u51vqjZVqUScCC6bYAfBMXmDteHGhmwlt1+QHL33A+U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FpT+fCHqLdmsyKUilTlW/XAdwcVFyIm9VMYmnENF/OKCoapqUrp8vYx8Bh3APSdQa 5m8zziq56Eeo1Upq9FZ3XOpnpkfcT6XJj58ODTfz5eDH8H0c73d7YxcWT/lT4XtsoF HdWlg7GdCZ+CUQUA0LFIzi5vDYSRTU7znIJVEC8M= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 30 Aug 2019 11:03:37 -0700 From: asinghal@codeaurora.org To: Arend Van Spriel Cc: johannes@sipsolutions.net, jouni@codeaurora.org, linux-wireless@vger.kernel.org, jjohnson@codeaurora.org, rmanohar@codeaurora.org Subject: Re: [PATCH] cfg80211: Convert 6 GHz channel frequency to channel number In-Reply-To: <544cab9b-8914-370d-c8a9-407ce88f6f32@broadcom.com> References: <1567117290-19295-1-git-send-email-asinghal@codeaurora.org> <544cab9b-8914-370d-c8a9-407ce88f6f32@broadcom.com> Message-ID: X-Sender: asinghal@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-08-30 03:45, Arend Van Spriel wrote: > On 8/30/2019 12:21 AM, Amar Singhal wrote: >> Enhance function ieee80211_frequency_to_channel by adding 6 GHz >> channels. > > This look very similar to what I submitted earlier: > > https://patchwork.kernel.org/patch/11073197/ > > Regards, > Arend - else if (freq <= 45000) /* DMG band lower limit */ + else if (freq < 5940) return (freq - 5000) / 5; + else if (freq <= 45000) /* DMG band lower limit */ + /* see 802.11ax D4.1 27.3.22.2 */ + return (freq - 5940) / 5; hi Arend, I see a small issue in your patch above; for frequency 5940, the channel number returned would be 0 which is an invalid channel. I guess 6 GHz center frequency numbers begin with 4945. rgds, Amar