From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Benjamin Berg <benjamin@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Benjamin Berg <benjamin.berg@intel.com>
Subject: Re: [PATCH wireless-next v2 2/8] wifi: mac80211: change public RX API to use link stations
Date: Tue, 4 Aug 2026 06:39:04 -0700 [thread overview]
Message-ID: <ed0a7291-22cc-47ec-8385-04920978eb32@oss.qualcomm.com> (raw)
In-Reply-To: <20260803143004.a2323a28062d.I4a2d45609e94b52654b10ec572e59a45d09c41f4@changeid>
On 8/3/2026 5:30 AM, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@intel.com>
>
> If a station is passed then the link ID also needs to be known. As such,
> it is a more natural API to simply pass the link station directly rather
> than pushing the link information into the RX status.
>
> Furthermore, having the link ID in the RX status is not actually correct
> because the link IDs are VIF specific and there may be multiple VIFs. In
> the case of a station this relationship is clear, but then one may as
> well use the link station.
>
> This patch only changes the API and emulates the old (incorrect)
> behaviour for now. The mac80211 RX code will be updated in later
> patches.
>
> Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>
>
> ---
>
> v2:
> * Remove now unused variable in rtw89
>
> v1:
> * Do not dereference NULL station
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
> drivers/net/wireless/ath/ath12k/dp_mon.c | 2 --
> drivers/net/wireless/ath/ath12k/dp_rx.c | 20 +++++++++++++----
> drivers/net/wireless/ath/ath12k/hw.h | 20 +++++++++--------
> drivers/net/wireless/ath/ath12k/wifi7/dp_rx.c | 20 ++++++++---------
> drivers/net/wireless/ath/ath12k/wifi7/dp_rx.h | 12 +++++-----
> drivers/net/wireless/ath/ath12k/wifi7/hw.c | 6 ++---
> drivers/net/wireless/ath/ath12k/wmi.c | 6 -----
> drivers/net/wireless/intel/iwlwifi/mld/rx.c | 7 +-----
> drivers/net/wireless/intel/iwlwifi/mvm/rx.c | 2 +-
> drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 6 ++---
> drivers/net/wireless/mediatek/mt76/mac80211.c | 22 +++++++++++--------
> drivers/net/wireless/realtek/rtw89/core.c | 7 ------
> .../wireless/virtual/mac80211_hwsim_main.c | 3 ---
> include/net/mac80211.h | 16 ++++++++++----
> net/mac80211/rx.c | 20 ++++++++++++-----
> 16 files changed, 91 insertions(+), 80 deletions(-)
btw please use get_maintainer.pl to get a list of all of the affected driver
maintainers and mailing lists and add them as recipients of the next version.
/jeff
next prev parent reply other threads:[~2026-08-04 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 12:30 [PATCH wireless-next v2 0/8] Adding NO_STA flag and reworking RX link resolution Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 1/8] wifi: iwlwifi: use link_sta internally to the driver Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 2/8] wifi: mac80211: change public RX API to use link stations Benjamin Berg
2026-08-04 13:39 ` Jeff Johnson [this message]
2026-08-03 12:30 ` [PATCH wireless-next v2 3/8] wifi: mac80211: refactor RX link_id and station handling Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 4/8] wifi: mac80211: rework RX packet handling Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 5/8] wifi: cfg80211: add attribute for TX/RX denoting there is no station Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 6/8] wifi: mac80211: report to cfg80211 when no STA is known for a frame Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 7/8] wifi: mac80211: pass station to ieee80211_tx_skb_tid Benjamin Berg
2026-08-03 12:30 ` [PATCH wireless-next v2 8/8] wifi: mac80211: pass error station if non-STA transmit was requested Benjamin Berg
2026-08-06 17:02 ` Ramasamy Kaliappan
2026-08-04 1:54 ` [PATCH wireless-next v2 0/8] Adding NO_STA flag and reworking RX link resolution Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed0a7291-22cc-47ec-8385-04920978eb32@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=benjamin.berg@intel.com \
--cc=benjamin@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox