public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>,
	"martin.blumenstingl@googlemail.com"
	<martin.blumenstingl@googlemail.com>
Subject: RE: rtl8822cs, mainline 6.16-rc7: kernel reports ' unsupported rf path'
Date: Wed, 23 Jul 2025 09:07:17 +0000	[thread overview]
Message-ID: <ed867462c8d945b28b2e913d1cd0c3d5@realtek.com> (raw)
In-Reply-To: <18989932-3578-4E45-BA8B-6C2C76FDE7FE@gmail.com>

Piotr Oniszczuk <piotr.oniszczuk@gmail.com> wrote:
> > Wiadomość napisana przez Ping-Ke Shih <pkshih@realtek.com> w dniu 23 lip 2025, o godz. 10:19:
> >
> > working state:
> >   rtw88: rtw_chip_parameter_setup:1859 hal->chip_version=0x493d30ea
> > non-working state:
> >   rtw88: rtw_chip_parameter_setup:1859 hal->chip_version=0x303030ea
> >
> > I'd try to read more times to see if it can become correct...
> > Also, I force to use correct value at the last iteration to see if it
> > can work even incorrect value of register 0xF0.
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> > index fa0ed39cb199..137418d1108d 100644
> > --- a/drivers/net/wireless/realtek/rtw88/main.c
> > +++ b/drivers/net/wireless/realtek/rtw88/main.c
> > @@ -1858,9 +1861,14 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
> >                return -EINVAL;
> >        }
> >
> > -       hal->chip_version = rtw_read32(rtwdev, REG_SYS_CFG1);
> > +       for (int i = 0; i < 20; i++) {
> > +       hal->chip_version = i == 19 ? 0x493d30ea : rtw_read32(rtwdev, REG_SYS_CFG1);
> >        hal->cut_version = BIT_GET_CHIP_VER(hal->chip_version);
> >        hal->mp_chip = (hal->chip_version & BIT_RTL_ID) ? 0 : 1;
> > +       printk("rtw88: %s:%d hal->chip_version=0x%x\n",
> > +               __func__, __LINE__, hal->chip_version);
> > +       mdelay(100);
> > +       }
> >        if (hal->chip_version & BIT_RF_TYPE_ID) {
> >                hal->rf_type = RF_2T2R;
> >                hal->rf_path_num = 2;
> >
> >
> 
> well - with above patch all starts to work well :-)
> 10 boots, 10 working wifi with correct scans.

Good.

> 
> demsg from working sys: https://termbin.com/bhs4

Unfortunately, the log said:
first read:
  rtw88: rtw_chip_parameter_setup:1860 hal->chip_version=0x303030ea
2nd~19th read:
  rtw88: rtw_chip_parameter_setup:1860 hal->chip_version=0x30303030

Not sure if I can use this pattern to make a workaround. I think the better
way would be to use firmware report to fix this. I'll try to make a patch
and get back to you soon.



  reply	other threads:[~2025-07-23  9:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 13:29 rtl8822cs, mainline 6.16-rc7: kernel reports ' unsupported rf path' Piotr Oniszczuk
2025-07-23  0:52 ` Ping-Ke Shih
2025-07-23  7:34   ` Piotr Oniszczuk
2025-07-23  7:50     ` Ping-Ke Shih
2025-07-23  8:02       ` Piotr Oniszczuk
2025-07-23  8:19         ` Ping-Ke Shih
2025-07-23  8:46           ` Piotr Oniszczuk
2025-07-23  9:07             ` Ping-Ke Shih [this message]
2025-07-23 11:14               ` Bitterblue Smith
2025-07-23 12:23                 ` Ping-Ke Shih
2025-07-23 13:02                   ` Piotr Oniszczuk
2025-07-24  0:52                     ` Ping-Ke Shih
2025-07-24  7:55                       ` Piotr Oniszczuk
2025-07-24  7:59                         ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed867462c8d945b28b2e913d1cd0c3d5@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=piotr.oniszczuk@gmail.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox