From: Deren Wu <deren.wu@mediatek.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
"Soul Huang" <Soul.Huang@mediatek.com>,
YN Chen <YN.Chen@mediatek.com>, Leon Yen <Leon.Yen@mediatek.com>,
Eric-SY Chang <Eric-SY.Chang@mediatek.com>,
KM Lin <km.lin@mediatek.com>,
Robin Chiu <robin.chiu@mediatek.com>,
CH Yeh <ch.yeh@mediatek.com>, Posh Sun <posh.sun@mediatek.com>,
Eric Liang <Eric.Liang@mediatek.com>,
Stella Chang <Stella.Chang@mediatek.com>,
"Evelyn Tsai" <evelyn.tsai@mediatek.com>,
Ryder Lee <ryder.lee@mediatek.com>,
"Shayne Chen" <shayne.chen@mediatek.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux-mediatek <linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] mt76: fix monitor rx FCS error in DFS channel
Date: Thu, 17 Mar 2022 15:02:13 +0800 [thread overview]
Message-ID: <ef6a0d876587e3efaa228f9d28f5a6f7b97e4aef.camel@mediatek.com> (raw)
In-Reply-To: <YjH/GCCfQoZ5OPPM@localhost.localdomain>
Hi Lore,
On Wed, 2022-03-16 at 16:15 +0100, Lorenzo Bianconi wrote:
> > From: Deren Wu <deren.wu@mediatek.com>
> >
> > When setup monitor mode in DFS channel, mt76 send CH_SWITCH_DFS to
> > fw for channel config. This would cause rx performance bad while
> > monitoring frames. Settings CH_SWITCH_NORMAL in monitor mode would
> > get the same performance as normal channels.
>
> Hi Deren,
>
> >
> > Reviewed-by: Shayne Chen <shayne.chen@mediatek.com>
> > Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt7615/mcu.c | 3 ++-
> > drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 3 ++-
> > drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 3 ++-
> > 3 files changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > index 390add3144c2..97e2a85cb728 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
> > @@ -2151,7 +2151,8 @@ int mt7615_mcu_set_chan_info(struct
> > mt7615_phy *phy, int cmd)
> > .center_chan2 = ieee80211_frequency_to_channel(freq2),
> > };
> >
> > - if (cmd == MCU_EXT_CMD(SET_RX_PATH))
> > + if (cmd == MCU_EXT_CMD(SET_RX_PATH) ||
> > + dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
>
> is this patch compliant with 802.11h DFS standard?
Monitor mode would not tx packets and still follow standard. We will
keep tracking this point to avoid violations.
Regards,
Deren
>
> Regards,
> Lorenzo
>
> > req.switch_reason = CH_SWITCH_NORMAL;
> > else if (phy->mt76->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > req.switch_reason = CH_SWITCH_SCAN_BYPASS_DPD;
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > index 10dc4bf5adec..c56d48342aaf 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
> > @@ -2833,7 +2833,8 @@ int mt7915_mcu_set_chan_info(struct
> > mt7915_phy *phy, int cmd)
> > }
> > #endif
> >
> > - if (cmd == MCU_EXT_CMD(SET_RX_PATH))
> > + if (cmd == MCU_EXT_CMD(SET_RX_PATH) ||
> > + dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
> > req.switch_reason = CH_SWITCH_NORMAL;
> > else if (phy->mt76->hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > req.switch_reason = CH_SWITCH_SCAN_BYPASS_DPD;
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > index 5ef8b24f0ab3..da2be050ed7c 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
> > @@ -863,7 +863,8 @@ int mt7921_mcu_set_chan_info(struct mt7921_phy
> > *phy, int cmd)
> > else
> > req.channel_band = chandef->chan->band;
> >
> > - if (cmd == MCU_EXT_CMD(SET_RX_PATH))
> > + if (cmd == MCU_EXT_CMD(SET_RX_PATH) ||
> > + dev->mt76.hw->conf.flags & IEEE80211_CONF_MONITOR)
> > req.switch_reason = CH_SWITCH_NORMAL;
> > else if (dev->mt76.hw->conf.flags & IEEE80211_CONF_OFFCHANNEL)
> > req.switch_reason = CH_SWITCH_SCAN_BYPASS_DPD;
> > --
> > 2.18.0
> >
next prev parent reply other threads:[~2022-03-17 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-16 9:51 [PATCH] mt76: fix monitor rx FCS error in DFS channel Deren Wu
2022-03-16 15:15 ` Lorenzo Bianconi
2022-03-17 7:02 ` Deren Wu [this message]
2022-03-17 9:03 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef6a0d876587e3efaa228f9d28f5a6f7b97e4aef.camel@mediatek.com \
--to=deren.wu@mediatek.com \
--cc=Eric-SY.Chang@mediatek.com \
--cc=Eric.Liang@mediatek.com \
--cc=Leon.Yen@mediatek.com \
--cc=Soul.Huang@mediatek.com \
--cc=Stella.Chang@mediatek.com \
--cc=YN.Chen@mediatek.com \
--cc=ch.yeh@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=km.lin@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=posh.sun@mediatek.com \
--cc=robin.chiu@mediatek.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox