From: Tamizh chelvam <tamizhr@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2 1/3] cfg80211: enable setting cqm rssi config for AP mode
Date: Wed, 21 Feb 2018 19:27:35 +0530 [thread overview]
Message-ID: <f0b1de1c18b8f20c793958570bb73005@codeaurora.org> (raw)
In-Reply-To: <1519046050.16723.8.camel@sipsolutions.net>
On 2018-02-19 18:44, Johannes Berg wrote:
> On Tue, 2018-02-13 at 14:50 +0530, Tamizh chelvam wrote:
>>
>> @@ -9903,8 +9906,10 @@ static int nl80211_set_cqm_rssi(struct
>> genl_info *info,
>> prev = thresholds[i];
>> }
>>
>> - if (wdev->iftype != NL80211_IFTYPE_STATION &&
>> - wdev->iftype != NL80211_IFTYPE_P2P_CLIENT)
>> + if ((wdev->iftype != NL80211_IFTYPE_STATION &&
>> + wdev->iftype != NL80211_IFTYPE_P2P_CLIENT &&
>> + !wiphy_ext_feature_isset(&rdev->wiphy,
>> + NL80211_EXT_FEATURE_AP_STA_CQM_RSSI_CONFIG)))
>> return -EOPNOTSUPP;
>
> This enables for everything though - not sure we want that?
I'll add vif type(AP, AP_VLAN and P2P_GO) check in the next version to
avoid enable this for all.
prev parent reply other threads:[~2018-02-21 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 9:20 [PATCHv2 0/3] cfg80211/mac80211: cqm rssi config for AP mode Tamizh chelvam
2018-02-13 9:20 ` [PATCHv2 1/3] cfg80211: enable setting " Tamizh chelvam
2018-02-19 13:14 ` Johannes Berg
2018-02-21 13:57 ` Tamizh chelvam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0b1de1c18b8f20c793958570bb73005@codeaurora.org \
--to=tamizhr@codeaurora.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).