From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Jes Sorensen <Jes.Sorensen@gmail.com>
Subject: Re: [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info
Date: Tue, 1 Nov 2022 19:49:31 +0200 [thread overview]
Message-ID: <f0fcd38a-83f6-e22a-b715-facf61d67b7d@gmail.com> (raw)
In-Reply-To: <87iljzudxl.fsf@kernel.org>
On 01/11/2022 13:11, Kalle Valo wrote:
> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
>
>> Replace two instances of bare pr_info with dev_info.
>>
>> Also make their messages a little more informative.
>>
>> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
>
> [...]
>
>> @@ -5420,7 +5421,8 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
>> rtl8xxxu_queue_rx_urb(priv, rx_urb);
>> break;
>> default:
>> - pr_info("failed to requeue urb %i\n", ret);
>> + dev_info(&priv->udev->dev,
>> + "failed to requeue urb with error %i\n", ret);
>
> Should this be dev_warn()? It looks like a warning.
>
Probably yes. I'll do that and also rebase everything.
next prev parent reply other threads:[~2022-11-01 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:30 [PATCH v3 1/5] wifi: rtl8xxxu: Add central frequency offset tracking Bitterblue Smith
2022-10-28 16:36 ` [PATCH v3 2/5] wifi: rtl8xxxu: Fix the CCK RSSI calculation Bitterblue Smith
2022-10-31 1:07 ` Ping-Ke Shih
2022-10-28 16:37 ` [PATCH v3 3/5] wifi: rtl8xxxu: Recognise all possible chip cuts Bitterblue Smith
2022-10-31 1:08 ` Ping-Ke Shih
2022-10-28 16:38 ` [PATCH v3 4/5] wifi: rtl8xxxu: Set IEEE80211_HW_SUPPORT_FAST_XMIT Bitterblue Smith
2022-10-31 1:08 ` Ping-Ke Shih
2022-10-28 16:40 ` [PATCH v3 5/5] wifi: rtl8xxxu: Use dev_info instead of pr_info Bitterblue Smith
2022-10-31 1:09 ` Ping-Ke Shih
2022-11-01 11:11 ` Kalle Valo
2022-11-01 17:49 ` Bitterblue Smith [this message]
2022-10-31 1:07 ` [PATCH v3 1/5] wifi: rtl8xxxu: Add central frequency offset tracking Ping-Ke Shih
2022-11-01 11:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0fcd38a-83f6-e22a-b715-facf61d67b7d@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=Jes.Sorensen@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).