Re: [PATCH wireless-next v2 0/2] wifi: cfg80211/mac80211: optimize station info handling

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2026-04-30 at 11:08 +0530, Sarika Sharma wrote:
> This series improve memory and logic efficiency in cfg80211 and
> mac80211 during NL80211_CMD_GET_STATION. Allocate link_sinfo and
> link tidstats objects only for valid links to reduce memory usage.
> Avoid setting non-MLO applicable fields for MLO stations to
> eliminate redundant operations and simplify the code path.

OK ... so taking a closer look now.

There's altogether too much going on in these patches - the first one is
really cfg80211 only and should be tagged as such (API updates across
consumers don't count), and I'm not sure the cfg80211_free_link_sinfo()
refactoring is useful - but if so maybe it should be NULL checked
inside?

The second patch *should* be mac80211 only, but magically removes also
the cfg80211 code ... I guess I can see that's no longer needed, but it
might better be a separate commit that explains that.

And finally, given that all of this is entirely dead code since my
commit c3f8d13357de ("wifi: nl80211: completely disable per-link stats
for now"), I'm not really all that interested in optimising it.

If you care so much about memory consumption then we can just delete the
code. If you actually care about exposing the information to userspace
(e.g. for the, entirely broken, MLO_SIGNAL_POLL in wpa_s) then you
should really fix those issues, and maybe then figure out any memory
issues.

johannes