From: Johannes Berg <johannes@sipsolutions.net>
To: Ryder Lee <ryder.lee@mediatek.com>, Felix Fietkau <nbd@nbd.name>
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Shayne Chen <shayne.chen@mediatek.com>,
Evelyn Tsai <evelyn.tsai@mediatek.com>,
Bo Jiao <bo.jiao@mediatek.com>,
Sujuan Chen <sujuan.chen@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [RFC PATCH 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue
Date: Tue, 25 May 2021 14:59:46 +0200 [thread overview]
Message-ID: <f1a1d5da376d0ec187079d1277d3628328fdd81c.camel@sipsolutions.net> (raw)
In-Reply-To: <a959135d3fe21118f38c33fc9ffb18124c1ef7ce.1621453091.git.ryder.lee@mediatek.com> (sfid-20210519_215633_470280_525C572D)
On Thu, 2021-05-20 at 03:56 +0800, Ryder Lee wrote:
>
> +static ieee80211_tx_result
> +ieee80211_xmit_fast_finish(struct ieee80211_sub_if_data *sdata,
> + struct sta_info *sta, u8 pn_offs,
> + struct ieee80211_key *key,
> + struct ieee80211_tx_data *tx)
> {
> + struct sk_buff *skb = tx->skb;
> struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
> struct ieee80211_hdr *hdr = (void *)skb->data;
> u8 tid = IEEE80211_NUM_TIDS;
>
>
>
>
> + if (!ieee80211_hw_check(&tx->local->hw, HAS_RATE_CONTROL))
> + if (ieee80211_tx_h_rate_ctrl(tx) != TX_CONTINUE)
> + return TX_DROP;
Probably nicer to roll that into one condition:
if (!...() &&
..._rate_ctrl(tx) != ...)
return TX_DROP;
johannes
prev parent reply other threads:[~2021-05-25 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 19:56 [RFC PATCH 1/4] mac80211: call ieee80211_tx_h_rate_ctrl() when dequeue Ryder Lee
2021-05-19 19:56 ` [RFC PATCH 2/4] mac80211: minstrel_ht: fix minstrel_aggr_check for encap offload Ryder Lee
2021-05-25 13:00 ` Johannes Berg
2021-05-28 1:54 ` Ryder Lee
2021-05-19 19:56 ` [RFC PATCH 3/4] mac80211: add rate control support " Ryder Lee
2021-05-19 19:56 ` [RFC PATCH 4/4] mt76: mt7615: add 802.11 encap offload support Ryder Lee
2021-05-25 12:59 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a1d5da376d0ec187079d1277d3628328fdd81c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=bo.jiao@mediatek.com \
--cc=evelyn.tsai@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox