From: Johannes Berg <johannes@sipsolutions.net>
To: Pawel Dembicki <paweldembicki@gmail.com>, linux-wireless@vger.kernel.org
Cc: Antony Kolitsos <zeusomighty@hotmail.com>,
Roopni Devanathan <quic_rdevanat@quicinc.com>,
Thomas Fourier <fourier.thomas@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mwl8k: inject DS Params IE into beacons if missing
Date: Mon, 10 Nov 2025 08:30:14 +0100 [thread overview]
Message-ID: <f1d7cd013d102972976d39e7fadef9e91a1c6056.camel@sipsolutions.net> (raw)
In-Reply-To: <20251110072359.2295615-2-paweldembicki@gmail.com>
Missing wifi: prefix.
> +
> + /* Inject a DS Params IE at the beginning of the IE list */
It hasn't really been called "IE" ("information element") in years, just
"element". Might want to update your terminology (at least for new
code), same also in subect. Also the element you're talking about is
(now?) "DSSS Parameter Set" in the spec.
> + buf_dst[hdr_len + 0] = WLAN_EID_DS_PARAMS;
> + buf_dst[hdr_len + 1] = 1;
> + buf_dst[hdr_len + 2] = hw->conf.chandef.chan->hw_value;
That's wrong, it should be after the SSID and Supported Rates and BSS
Membership Selectors elements.
Normally this doesn't matter much, but I wouldn't be surprised if there
were implementations that assume the SSID is at a fixed first position.
johannes
prev parent reply other threads:[~2025-11-10 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 7:23 [PATCH] mwl8k: inject DS Params IE into beacons if missing Pawel Dembicki
2025-11-10 7:30 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d7cd013d102972976d39e7fadef9e91a1c6056.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=fourier.thomas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=paweldembicki@gmail.com \
--cc=quic_rdevanat@quicinc.com \
--cc=zeusomighty@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox