From: Ping-Ke Shih <pkshih@realtek.com>
To: Shengyu Qu <wiagn233@outlook.com>, Felix Fietkau <nbd@nbd.name>,
"lorenzo@kernel.org" <lorenzo@kernel.org>,
"ryder.lee@mediatek.com" <ryder.lee@mediatek.com>,
"shayne.chen@mediatek.com" <shayne.chen@mediatek.com>,
"sean.wang@mediatek.com" <sean.wang@mediatek.com>,
"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"miriam.rachel.korenblit@intel.com"
<miriam.rachel.korenblit@intel.com>,
"howard-yh.hsu@mediatek.com" <howard-yh.hsu@mediatek.com>,
"greearb@candelatech.com" <greearb@candelatech.com>,
"chui-hao.chiu@mediatek.com" <chui-hao.chiu@mediatek.com>,
"mingyen.hsieh@mediatek.com" <mingyen.hsieh@mediatek.com>,
"quic_adisi@quicinc.com" <quic_adisi@quicinc.com>,
"sujuan.chen@mediatek.com" <sujuan.chen@mediatek.com>,
"gustavoars@kernel.org" <gustavoars@kernel.org>,
"bo.jiao@mediatek.com" <bo.jiao@mediatek.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Subject: RE: [PATCH v9 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled
Date: Tue, 11 Mar 2025 08:29:00 +0000 [thread overview]
Message-ID: <f25427774f1147d995d9fd86da071ef3@realtek.com> (raw)
In-Reply-To: <TYCPR01MB84379512D874F722A0466D0A98D12@TYCPR01MB8437.jpnprd01.prod.outlook.com>
> >>
> >> mt76_connac_mcu_del_wtbl_all(&dev->mt76);
> >>
> >> - if ((mtk_wed_device_active(&dev->mt76.mmio.wed) &&
> >> - is_mt7915(&dev->mt76)) ||
> >> - !mtk_wed_get_rx_capa(&dev->mt76.mmio.wed))
> >> - mt7915_mcu_wa_cmd(dev, MCU_WA_PARAM_CMD(CAPABILITY), 0, 0, 0);
> >> +#if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> >
> > In MT76, there are two styles:
> > #if IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)
> > #ifdef CONFIG_NET_MEDIATEK_SOC_WED
> >
> > I think both are correct. Just wonder why not making them consistent.
> Seems you didn't receive Felix's email, check this:
> https://lore.kernel.org/linux-wireless/71ed8398-4619-4793-804d-77cad36e7402@nbd.name/
>
I was aware of this. Felix pointed out 'if (IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED))'
will lead build error. But what I mentioned here were '#if' and
'#ifdef' (preprocess directive).
Anyway, ignore this.
prev parent reply other threads:[~2025-03-11 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 15:35 [PATCH v9 RESEND] wifi: mt76: mt7915: add wds support when wed is enabled Shengyu Qu
2025-03-10 0:33 ` Ping-Ke Shih
2025-03-10 10:33 ` Shengyu Qu
2025-03-10 10:41 ` Felix Fietkau
2025-03-10 12:41 ` Shengyu Qu
2025-03-11 0:47 ` Ping-Ke Shih
2025-03-11 5:14 ` Shengyu Qu
2025-03-11 8:29 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25427774f1147d995d9fd86da071ef3@realtek.com \
--to=pkshih@realtek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bo.jiao@mediatek.com \
--cc=chui-hao.chiu@mediatek.com \
--cc=greearb@candelatech.com \
--cc=gustavoars@kernel.org \
--cc=howard-yh.hsu@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mingyen.hsieh@mediatek.com \
--cc=miriam.rachel.korenblit@intel.com \
--cc=nbd@nbd.name \
--cc=quic_adisi@quicinc.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
--cc=sujuan.chen@mediatek.com \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox