From: Wright Feng <Wright.Feng@cypress.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
"franky.lin@broadcom.com" <franky.lin@broadcom.com>,
"hante.meuleman@broadcom.com" <hante.meuleman@broadcom.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
Chi-Hsien Lin <Chi-Hsien.Lin@cypress.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"brcm80211-dev-list.pdl@broadcom.com"
<brcm80211-dev-list.pdl@broadcom.com>
Subject: Re: [PATCH] brcmfmac: remove the duplicate line of sending mail box interrupt
Date: Thu, 25 Apr 2019 03:37:16 +0000 [thread overview]
Message-ID: <f25a4565-ef2e-4a1d-bd5b-76b3192eee50@cypress.com> (raw)
In-Reply-To: <164b59e8-633b-84cc-179f-9bdd7ec696a7@broadcom.com>
On 2019/4/24 下午 04:46, Arend Van Spriel wrote:
> On 4/24/2019 7:24 AM, Arend Van Spriel wrote:
>> On April 22, 2019 4:47:31 AM Wright Feng <Wright.Feng@cypress.com> wrote:
>>
>>> The line is duplicate so remove it from pcie.c. We don't need to send
>>> host to dongle mail box interrupt twice after writing data.
>>
>> Hi Wright,
>>
>> Thanks for the patch. I am a bit early as it is not uncommon that
>> hardware requires an extra kick. Might be the case here for some
>> chips. Will follow-up on it.
>
> Hi Wright,
>
> I checked in our dhd driver code and it also does a double write. Turns
> out to be a hardware workaround so we need to keep this. It is worth a
> comment though.
>
Hi Arend,
Thanks for the information.
NXP and I worked on suspend/resume stress test issue with 1FD(4359b1)
two months ago, and we found one of root cause is duplicate mailbox
interrupt.
I've checked the history of the hardware issue internally, and it seems that
the issue is only on PCIEGEN2 revision 1 to 13.
So is that okay we can skip the hardware workaround when PCIEGEN2
revision is greater than 13 and add the comment on it in my patch v2?
Regards,
Wright
> Thanks,
> Arend
prev parent reply other threads:[~2019-04-25 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 2:47 [PATCH] brcmfmac: remove the duplicate line of sending mail box interrupt Wright Feng
2019-04-24 5:24 ` Arend Van Spriel
2019-04-24 8:46 ` Arend Van Spriel
2019-04-25 3:37 ` Wright Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25a4565-ef2e-4a1d-bd5b-76b3192eee50@cypress.com \
--to=wright.feng@cypress.com \
--cc=Chi-Hsien.Lin@cypress.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox