From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BC46CD68FB for ; Tue, 10 Oct 2023 07:54:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442572AbjJJHyn (ORCPT ); Tue, 10 Oct 2023 03:54:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442619AbjJJHyi (ORCPT ); Tue, 10 Oct 2023 03:54:38 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A0EBA4; Tue, 10 Oct 2023 00:54:37 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-405497850dbso49741515e9.0; Tue, 10 Oct 2023 00:54:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696924476; x=1697529276; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iwwM7auPgZJMU7dH/X5o56/hwua6iH2A1QFl6/0EOd0=; b=V6xfKpPBZTbS6eVz4iMpEXFUchDmqhSn0Cwyc05jiqi3vR+WJlu8pppJilTXDdPlph PRxCD+95LLdqprM9L1zKPOhVed3FZHHu1oWgnQg3WkR0M4yReUcuvDRnv9JQBNeoGckW Trxpvnb4FViHX7Ws50B1yqA7K7dNiR25T8QMYuTcw46j5kkULb8f+PiyMBHUbqGScWbb IonN3Fuh3o4WZgOBRyGGm+B9Z+Cj+go1Bm9XMqfETtq+st9KexgWqleHNIMzyAx6kjYg PoLoq+UqBNbtRvLOkVQTSpyXjbrokXX0trbGwxFfttb9WUziBJ0lPLN6NeHtIfi9xQhg toxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696924476; x=1697529276; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iwwM7auPgZJMU7dH/X5o56/hwua6iH2A1QFl6/0EOd0=; b=CxsH1TWc3e06dq6V0BkWtT6qZOjCbTU0dGwcEVsPhw7KncaukXjg3PuTdBexUE0qK0 DXrPwcPibKKRFOuqIpbnhV4Emr9/S/L5Swr9hX00dRhzRacW9P9dBOar5vz5vQzsuVsv xGZtL2450/dF6HW6e4B03HEk2rO7uENJv2lP87LsKI7617r6szi4AaFXjyMESx+YQO2J GoYAJpJYUYJolOorlTioQTpEtU4ETQ7rPnvXIQHWG2qFmGTVdPsqksUwobh8fNPvHkQ9 znp017v7yGsNzt5QrgZaZOOO9PPa93tfcbqFUzx3/6sENdHllkMAQReU/NnlnvvVoiKV knjw== X-Gm-Message-State: AOJu0YzD0SP6pFdT8kBmlaolcwJLo3aPHrLWbC1LWs0fufkCwPaa10sA u/lRZ/lCna9ymacsAFMfAvI= X-Google-Smtp-Source: AGHT+IFoXHF3xhB1R1QbXfa6gtatnLXym3Q5nnEunh6zFeATAVA0tqJjWKSQ447yVOYMirHfwQlOJg== X-Received: by 2002:a5d:500b:0:b0:319:8a66:f695 with SMTP id e11-20020a5d500b000000b003198a66f695mr13345455wrt.55.1696924475419; Tue, 10 Oct 2023 00:54:35 -0700 (PDT) Received: from [192.168.0.101] ([77.126.80.27]) by smtp.gmail.com with ESMTPSA id z3-20020a056000110300b0031c6581d55esm11802488wrw.91.2023.10.10.00.54.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 00:54:35 -0700 (PDT) Message-ID: Date: Tue, 10 Oct 2023 10:54:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next v3 3/5] netdev: replace napi_reschedule with napi_schedule Content-Language: en-US To: Christian Marangi , Jason Gunthorpe , Leon Romanovsky , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chris Snook , Raju Rangoju , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Douglas Miller , Nick Child , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Haren Myneni , Rick Lindsley , Dany Madden , Thomas Falcon , Tariq Toukan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Krzysztof Halasa , Kalle Valo , Jeff Johnson , Gregory Greenman , Chandrashekar Devegowda , Intel Corporation , Chiranjeevi Rapolu , Liu Haijun , M Chetan Kumar , Ricardo Martinez , Loic Poulain , Sergey Ryazanov , Johannes Berg , Yuanjun Gong , Alex Elder , Bhupesh Sharma , Simon Horman , Rob Herring , Bailey Forrest , Junfeng Guo , "Gustavo A. R. Silva" , Ziwei Xiao , Rushil Gupta , Thomas Gleixner , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Krzysztof Kozlowski , Yuri Karpov , Andrew Lunn , Zheng Zengkai , Dawei Li , Anjaneyulu , Benjamin Berg , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org References: <20231009133754.9834-1-ansuelsmth@gmail.com> <20231009133754.9834-3-ansuelsmth@gmail.com> From: Tariq Toukan In-Reply-To: <20231009133754.9834-3-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 09/10/2023 16:37, Christian Marangi wrote: > Now that napi_schedule return a bool, we can drop napi_reschedule that > does the same exact function. The function comes from a very old commit > bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct > net_device") and the purpose is actually deprecated in favour of > different logic. > > Convert every user of napi_reschedule to napi_schedule. > > Signed-off-by: Christian Marangi > Acked-by: Jeff Johnson # ath10k > Acked-by: Nick Child # ibm > Acked-by: Marc Kleine-Budde # for can/dev/rx-offload.c > Reviewed-by: Eric Dumazet > --- > Changes v3: > - Add Reviewed-by tag > Changes v2: > - Add ack tag > --- > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 ++-- > drivers/net/can/dev/rx-offload.c | 2 +- > drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +- > drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 2 +- > drivers/net/ethernet/ezchip/nps_enet.c | 2 +- > drivers/net/ethernet/google/gve/gve_main.c | 2 +- > drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +- > drivers/net/ethernet/ibm/emac/mal.c | 2 +- > drivers/net/ethernet/ibm/ibmveth.c | 2 +- > drivers/net/ethernet/ibm/ibmvnic.c | 2 +- > drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- > drivers/net/ethernet/ni/nixge.c | 2 +- > drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +- > drivers/net/ethernet/xscale/ixp4xx_eth.c | 4 ++-- > drivers/net/fjes/fjes_main.c | 2 +- > drivers/net/wan/ixp4xx_hss.c | 4 ++-- > drivers/net/wireless/ath/ath10k/pci.c | 2 +- > drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 2 +- > include/linux/netdevice.h | 10 ---------- > 19 files changed, 21 insertions(+), 31 deletions(-) > ... > diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > index 332472fe4990..a09b6e05337d 100644 > --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c > +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c > @@ -400,7 +400,7 @@ void mlx4_en_recover_from_oom(struct mlx4_en_priv *priv) > for (ring = 0; ring < priv->rx_ring_num; ring++) { > if (mlx4_en_is_ring_empty(priv->rx_ring[ring])) { > local_bh_disable(); > - napi_reschedule(&priv->rx_cq[ring]->napi); > + napi_schedule(&priv->rx_cq[ring]->napi); > local_bh_enable(); > } > } For mlx4 part: Acked-by: Tariq Toukan