From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76EEBC4332F for ; Fri, 4 Nov 2022 16:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbiKDQZ0 (ORCPT ); Fri, 4 Nov 2022 12:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbiKDQZZ (ORCPT ); Fri, 4 Nov 2022 12:25:25 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E844F10; Fri, 4 Nov 2022 09:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=mueebaL38FcUSyeQjIobsTZF1EWJPQVH0pYABKEMbSQ=; t=1667579123; x=1668788723; b=ULmpVSbtjPRgyR1XU6rdZFqUGovGHTjTIIopU0I4qrXHe7X WaAJEnOzPNvw8W4wQ7D2hgN4L0E+pDlaSd32FuHmV/FOeMsdlrIKW3BpoXFtl86y2B3aRs2HZeeJq QsBisjVVpVx3N/WErDbyrNNkYrZDoyVx4M49wKXN8l63wN1vqyP5pFyNp/Im61515BTwJgahiytPO TImgySX6hY43mCsbdsnN0I2oTdC6FMb/4ROXSrVuI9RSceyAvMAA4X7mQtJ7pzemxhGAvGQJJK7Kl JaFAaFRVSMny9xtoP1n1RbYY4eviO4promqjDWMsxUEnS0islwXBgE8bk5Y2/xQg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1oqzVG-008utM-2M; Fri, 04 Nov 2022 17:25:10 +0100 Message-ID: Subject: Re: [PATCH v3] wifi: rsi: Fix handling of 802.3 EAPOL frames sent via control port From: Johannes Berg To: Marek Vasut , linux-wireless@vger.kernel.org Cc: Angus Ainslie , Jakub Kicinski , Kalle Valo , Martin Fuzzey , Martin Kepplinger , Prameela Rani Garnepudi , Sebastian Krzyszkowiak , Siva Rebbagondla , netdev@vger.kernel.org Date: Fri, 04 Nov 2022 17:25:09 +0100 In-Reply-To: References: <20221104155841.213387-1-marex@denx.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org (removing Amitkumar Karwar as that keeps bouncing) On Fri, 2022-11-04 at 17:23 +0100, Johannes Berg wrote: > On Fri, 2022-11-04 at 17:09 +0100, Marek Vasut wrote: > >=20 > > In V2 it was suggested I deduplicate this into a separate function,=20 > > since the test is done in multiple places. I would like to keep it=20 > > deduplicated. >=20 > Well, it's now a lot simpler, so one might argue that it's not needed. >=20 > But anyway you're touching the hot-path of this driver, and making it an > inline still keeps it de-duplicated, so not sure why you wouldn't just > move the rsi_is_tx_eapol into the header file as static inline? >=20 Though honestly, if we thought it was worth deduplicating a simple bit check like that, we could define an inline helper in mac80211.h. I'm not really convinced it is :) But hey, that's not my driver, so ultimately I don't _really_ care so much. johannes