public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Breno Leitao <leitao@debian.org>, Kalle Valo <kvalo@kernel.org>
Cc: "leit@meta.com" <leit@meta.com>,
	"open list:REALTEK WIRELESS DRIVER (rtw89)"
	<linux-wireless@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH wireless] wifi: rtw89: Un-embed dummy device
Date: Thu, 25 Apr 2024 05:52:54 +0000	[thread overview]
Message-ID: <f46ae94488d1468e9a9a669320e4cfb9@realtek.com> (raw)
In-Reply-To: <20240424182351.3936556-1-leitao@debian.org>

Breno Leitao <leitao@debian.org> wrote:
> Embedding net_device into structures prohibits the usage of flexible
> arrays in the net_device structure. For more details, see the discussion
> at [1].
> 
> Un-embed the net_device from the private struct by converting it
> into a pointer. Then use the leverage the new alloc_netdev_dummy()
> helper to allocate and initialize dummy devices.
> 
> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

I think this patch should go via net-next tree, because wireless-next tree
doesn't have patch of dummy devices yet.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/core.c | 11 ++++++++---
>  drivers/net/wireless/realtek/rtw89/core.h |  4 ++--
>  drivers/net/wireless/realtek/rtw89/pci.c  |  6 +++++-
>  3 files changed, 15 insertions(+), 6 deletions(-)
> 
> PS: This is compile-tested only due to lack of hardware.

I picked this patch to local net-next tree, and tested on RTL8852BE, RTL8852C
and RTL8922AE.

Tested-by: Ping-Ke Shih <pkshih@realtek.com>



  reply	other threads:[~2024-04-25  5:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-24 18:23 [PATCH wireless] wifi: rtw89: Un-embed dummy device Breno Leitao
2024-04-25  5:52 ` Ping-Ke Shih [this message]
2024-04-25  5:57   ` Kalle Valo
2024-04-25  6:00     ` Kalle Valo
2024-04-25  6:15       ` Ping-Ke Shih
2024-05-09  7:48         ` Breno Leitao
2024-05-09  7:59           ` Ping-Ke Shih
2024-05-09  9:48             ` Kalle Valo
2024-05-09 11:03               ` Breno Leitao
2024-05-09  6:14 ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f46ae94488d1468e9a9a669320e4cfb9@realtek.com \
    --to=pkshih@realtek.com \
    --cc=kvalo@kernel.org \
    --cc=leit@meta.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox