From: Pkshih <pkshih@realtek.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] mac80211: consider Order bit to fill CCMP AAD
Date: Wed, 13 Apr 2022 00:24:13 +0000 [thread overview]
Message-ID: <f528e86d086c49488c9adebc835f3f88@realtek.com> (raw)
In-Reply-To: <da208535ec78e867f3b1d881cd5784bdaea1b1c2.camel@sipsolutions.net>
> -----Original Message-----
> From: Johannes Berg <johannes@sipsolutions.net>
> Sent: Tuesday, April 12, 2022 1:47 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: linux-wireless@vger.kernel.org
> Subject: Re: [PATCH] mac80211: consider Order bit to fill CCMP AAD
>
> On Tue, 2022-04-12 at 00:37 +0000, Pkshih wrote:
> > After I fix my driver, I don't need this, but I think it is worth to
> > have
> > this patch.
>
> OK. But I guess that means no hurry.
Yes.
>
> Yeah, thinking about that, I guess you're right. Maybe we can express
> the 22 a bit better (some headerlen - 2 with a comment?), but I can look
> at that when I apply the patch.
How about replacing 22 by 2 + 6 + 6 + 6 + 2
because of "FC | A1 | A2 | A3 | SC | [A4] | [QC]" ?
Ping-Ke
next prev parent reply other threads:[~2022-04-13 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-24 0:48 [PATCH] mac80211: consider Order bit to fill CCMP AAD Ping-Ke Shih
2022-04-11 9:11 ` Johannes Berg
2022-04-12 0:37 ` Pkshih
2022-04-12 5:47 ` Johannes Berg
2022-04-13 0:24 ` Pkshih [this message]
2022-05-06 8:02 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f528e86d086c49488c9adebc835f3f88@realtek.com \
--to=pkshih@realtek.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).