From: Ping-Ke Shih <pkshih@realtek.com>
To: rafad900 <rafad900@gmail.com>,
"Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH rtw-next v4] wifi: rtl8xxxu: Use local 'dev' variable for dev_warn()
Date: Tue, 18 Aug 2026 07:47:46 +0000 [thread overview]
Message-ID: <f69bdcc116f04c3c865235873827abf9@realtek.com> (raw)
In-Reply-To: <20260818052441.1651077-1-rafad900@gmail.com>
rafad900 <rafad900@gmail.com> wrote:
> @@ -2241,7 +2242,7 @@ int rtl8xxxu_init_phy_regs(struct rtl8xxxu_priv *priv,
>
> ret = rtl8xxxu_write32(priv, reg, val);
> if (ret != sizeof(val)) {
> - dev_warn(&priv->udev->dev,
> + dev_warn(dev,
> "Failed to initialize PHY\n");
Strighten
> return -EAGAIN;
> }
[...]
> @@ -5869,6 +5872,7 @@ static void rtl8xxxu_rx_urb_work(struct work_struct *work)
> int ret;
>
> priv = container_of(work, struct rtl8xxxu_priv, rx_urb_wq);
> + struct device *dev = &priv->udev->dev;
Don't put declaration in the middle.
> INIT_LIST_HEAD(&local);
>
> spin_lock_irqsave(&priv->rx_urb_lock, flags);
[...]
prev parent reply other threads:[~2026-08-18 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 5:24 [PATCH rtw-next v4] wifi: rtl8xxxu: Use local 'dev' variable for dev_warn() rafad900
2026-08-18 7:47 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69bdcc116f04c3c865235873827abf9@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafad900@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox