From: Ping-Ke Shih <pkshih@realtek.com>
To: Fiona Klute <fiona.klute@gmx.de>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "Kalle Valo" <kvalo@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"Pavel Machek" <pavel@ucw.cz>, "Ondřej Jirman" <megi@xff.cz>
Subject: RE: [PATCH v3 0/9] rtw88: Add support for RTL8723CS/RTL8703B
Date: Mon, 11 Mar 2024 04:27:51 +0000 [thread overview]
Message-ID: <f77fa5db0b3b4145878bf47f9ba11c8b@realtek.com> (raw)
In-Reply-To: <20240309115650.367204-1-fiona.klute@gmx.de>
>
> v3 has only minor changes requested in review, so I hope it's good to
> merge now:
> * rtw8703b.h: #include rtw8723x.h instead of linux/types.h and
> linux/compiler_attributes.h
> * rtw8703b_tables.c: #include rtw8703b_tables.h
> * rtw8703b.c: define TRANS_SEQ_END without braces (checkpatch.pl
> doesn't like this, but I assume maintainer request overrides it)
v3 is almost fine to me. Only one minor comment on patch 5/9.
Please send v4 to revise it.
I also have run sparse and smatch with this patchset, no error/warning.
Ping-Ke
prev parent reply other threads:[~2024-03-11 4:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 11:56 [PATCH v3 0/9] rtw88: Add support for RTL8723CS/RTL8703B Fiona Klute
2024-03-09 11:56 ` [PATCH v3 1/9] wifi: rtw88: Shared module for rtw8723x devices Fiona Klute
2024-03-09 11:56 ` [PATCH v3 2/9] wifi: rtw88: Debug output for rtw8723x EFUSE Fiona Klute
2024-03-09 11:56 ` [PATCH v3 3/9] wifi: rtw88: Add definitions for 8703b chip Fiona Klute
2024-03-09 11:56 ` [PATCH v3 4/9] wifi: rtw88: Add rtw8703b.h Fiona Klute
2024-03-09 11:56 ` [PATCH v3 5/9] wifi: rtw88: Add rtw8703b.c Fiona Klute
2024-03-11 3:54 ` Ping-Ke Shih
2024-03-09 11:56 ` [PATCH v3 6/9] wifi: rtw88: Add rtw8703b_tables.h Fiona Klute
2024-03-09 11:56 ` [PATCH v3 7/9] wifi: rtw88: Add rtw8703b_tables.c Fiona Klute
2024-03-09 11:56 ` [PATCH v3 8/9] wifi: rtw88: Reset 8703b firmware before download Fiona Klute
2024-03-09 11:56 ` [PATCH v3 9/9] wifi: rtw88: SDIO device driver for RTL8723CS Fiona Klute
2024-03-11 4:27 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f77fa5db0b3b4145878bf47f9ba11c8b@realtek.com \
--to=pkshih@realtek.com \
--cc=fiona.klute@gmx.de \
--cc=kvalo@kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=pavel@ucw.cz \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).