RE: [PATCH] rtlwifi: rtl8821ae: Remove dead code in rtl8821ae_update_hal_rate_table()

[Ping-Ke Shih <pkshih@realtek.com>]

Chelsy Ratnawat <chelsyratnawat2001@gmail.com> wrote:
> Sent: Saturday, April 4, 2026 12:54 AM
> The variable 'mimo_ps' is initialized to IEEE80211_SMPS_OFF and never
> modified throughout the function. This makes the condition checking for
> IEEE80211_SMPS_STATIC always evaluate to false, rendering the entire
> if-branch unreachable dead code.
> 
> The error was reported by Coverity Scan.
> 
> Signed-off-by: Chelsy Ratnawat <chelsyratnawat2001@gmail.com>
> ---
>  .../wireless/realtek/rtlwifi/rtl8821ae/hw.c   | 19 +++++++------------
>  1 file changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 3a4a33476205..81d36041a79b 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -3257,7 +3257,6 @@ static void rtl8821ae_update_hal_rate_table(struct ieee80211_hw *hw,
>         u32 ratr_value;
>         u8 ratr_index = 0;
>         u8 b_nmode = mac->ht_enable;
> -       u8 mimo_ps = IEEE80211_SMPS_OFF;
>         u16 shortgi_rate;
>         u32 tmp_ratr_value;
>         u8 curtxbw_40mhz = mac->bw_40;
> @@ -3288,19 +3287,15 @@ static void rtl8821ae_update_hal_rate_table(struct ieee80211_hw *hw,
>         case WIRELESS_MODE_N_24G:
>         case WIRELESS_MODE_N_5G:
>                 b_nmode = 1;
> -               if (mimo_ps == IEEE80211_SMPS_STATIC) {
> -                       ratr_value &= 0x0007F005;
> -               } else {
> -                       u32 ratr_mask;
> +               u32 ratr_mask;

Declare local variable at top of scope or function.

Otherwise, looks fine to me. 

> 
> -                       if (get_rf_type(rtlphy) == RF_1T2R ||
> -                           get_rf_type(rtlphy) == RF_1T1R)
> -                               ratr_mask = 0x000ff005;
> -                       else
> -                               ratr_mask = 0x0f0ff005;
> +               if (get_rf_type(rtlphy) == RF_1T2R ||
> +                   get_rf_type(rtlphy) == RF_1T1R)
> +                       ratr_mask = 0x000ff005;
> +               else
> +                       ratr_mask = 0x0f0ff005;
> 
> -                       ratr_value &= ratr_mask;
> -               }
> +               ratr_value &= ratr_mask;
>                 break;
>         default:
>                 if (rtlphy->rf_type == RF_1T2R)
> --
> 2.43.0