From: Johannes Berg <johannes@sipsolutions.net>
To: Linus Probert <linus.probert@gmail.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Kalle Valo <kvalo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"open list:INTEL WIRELESS WIFI LINK (iwlwifi)"
<linux-wireless@vger.kernel.org>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iwlwifi: fix style warnings in iwl-drv.c
Date: Thu, 03 Nov 2022 21:52:34 +0100 [thread overview]
Message-ID: <f933bc0de15a4301e43207fe989e519fa25db31f.camel@sipsolutions.net> (raw)
In-Reply-To: <Y2QTLgWVO2sZMnOb@firefly>
On Thu, 2022-11-03 at 20:14 +0100, Linus Probert wrote:
> Running checkpatch on iwl-drv.c produced a series of minor style
> warnings. Most of them have been removed. There are some remaining
> regarding multiple lines of quoted strings as well as some warnings
> where the suggested fix produces a new warning.
No thanks.
Some of these really shouldn't be fixed (like strings be broken?! I
thought we stopped this nonsense even in checkpatch), and anyway, this
will probably just cause conflicts for no good reason.
johannes
prev parent reply other threads:[~2022-11-03 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 19:14 [PATCH] iwlwifi: fix style warnings in iwl-drv.c Linus Probert
2022-11-03 20:52 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f933bc0de15a4301e43207fe989e519fa25db31f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.greenman@intel.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linus.probert@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox