From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BBD333E7 for ; Wed, 19 Feb 2025 04:49:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739940577; cv=none; b=jgtiDtFmclK89Jk59vj8tGhIkNjgyVqyKoR1p6tszvt3CJfYd/AgwIa70s10xYm2JdlvG5DA2wdt4M+DRr9qC8K092QhuYhjm1vraz34VkhIUiNLp27C3C8NszgP7Wfi4gfGq/QkWSAarDZt5NapjAm+d/Bk4jyvmoynMz64Qzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739940577; c=relaxed/simple; bh=GhSZdek+DqYpSvt4+seMEyRP7HA/rHsuUZ9ZpPrFhKY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=DxAOkEDqJNNJYauWcnxq5+U5vtwGB+KwNd73fGNC5hizWci2EhIaMK0BRQTPa7Z3WVHXuYHa9FZbzIvH0sUit5PsQMDOOQ1+lbV0Jx/ajLGBTQLLxhGw7/g6pC8dfJCZmv4z51n4Bz+vZnR5hNSERY1p/jwd2DZgZPTEDZ/UDXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=iTN/G+mM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="iTN/G+mM" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51IIwLsp007560; Wed, 19 Feb 2025 04:49:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dBDez1gHWr6DJVbenzZtY1TU72AbOHG5WgdgavhFaAs=; b=iTN/G+mMGEq8dP7P av0GPRT0LeF7ems+4eM3UW6gVjhnFCNOtee/yae0U+yFegOjiSqswqPvGdnCUXBD qMUDWIske4YVopDeB7/eiaw2NqT7NOz4vV4uuLOyuNK+ZRg3ZII45J2XmSbUvyJu Zr6+zaIyFY9jT70g+DNE9Ztk9AwuN8sIINUsoNEqt4jTV5g1f9jxq9wlzs4zi90M WwZ2WobENaOOCbMZsLacUmgQfcFTmxlISXTdixbz/cgS8Gc+EjN/xMOR8RheFgKG r5TeyjWt6LVR3baHukKff587N5oGmPlfrrweparwr1JKYMo52pKcqJmNkezTy3U6 wg9iuQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44vyy2s7w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 04:49:34 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 51J4nX8m007933 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2025 04:49:33 GMT Received: from [10.216.26.155] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 18 Feb 2025 20:49:31 -0800 Message-ID: Date: Wed, 19 Feb 2025 10:19:28 +0530 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v10 3/4] wifi: ath12k: use correct WMI command to set country code for WCN7850 Content-Language: en-US To: Kang Yang , CC: References: <20250212063200.1631-1-quic_kangyang@quicinc.com> <20250212063200.1631-4-quic_kangyang@quicinc.com> From: Vasanthakumar Thiagarajan In-Reply-To: <20250212063200.1631-4-quic_kangyang@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: iZrElE5KO0xzTyVrNW-tEh1qTRHh0pjz X-Proofpoint-GUID: iZrElE5KO0xzTyVrNW-tEh1qTRHh0pjz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-19_02,2025-02-18_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 mlxscore=0 bulkscore=0 impostorscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502190034 On 2/12/2025 12:01 PM, Kang Yang wrote: > From: Wen Gong > > When userspace try to set country code by NL80211_REGDOM_SET_BY_USER > hint(like iw reg set XX), it will pass new country code to ath12k. > Then ath12k will set this new country code to firmware by > WMI_SET_INIT_COUNTRY_CMDID. But for WCN7850, this WMI command won't > take effect. > > For AP based chips(QCN92xx), WMI_SET_INIT_COUNTRY_CMDID is the correct > command. However, for STATION based chips(WCN7850), it need to use > WMI_SET_CURRENT_COUNTRY_CMDID. > > Add flag current_cc_support in hardware parameters. It is used to > distinguish AP/STA platform. After that, the firmware will work > normal and the regulatory feature works well for WCN7850. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Wen Gong > Signed-off-by: Kang Yang The actual patch looks good to me other than a comment on the patch order Reviewed-by: Vasanthakumar Thiagarajan