From: Saheed Bolarinwa <refactormyself@gmail.com>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: helgaas@kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bjorn@helgaas.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*()
Date: Mon, 13 Jul 2020 20:02:20 +0200 [thread overview]
Message-ID: <fa99aee8-86ee-558f-cb6f-761519c13159@gmail.com> (raw)
In-Reply-To: <87wo37a5s5.fsf@codeaurora.org>
Fixed
On 7/13/20 3:44 PM, Kalle Valo wrote:
> + linux-wireless
>
> Saheed Olayemi Bolarinwa <refactormyself@gmail.com> writes:
>
>> From: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
>>
>> Cc: bjorn@helgaas.com,
>> skhan@linuxfoundation.org,
>> linux-pci@vger.kernel.org,
>> linux-kernel-mentees@lists.linuxfoundation.org,
>> linux-kernel@vger.kernel.org,
>> Stanislaw Gruszka <stf_xl@wp.pl>,
>> linux-wireless@vger.kernel.org,
>> netdev@vger.kernel.org
>>
>> On failure pcie_capability_read_dword() sets it's last parameter, val
>> to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
>> failure. This would introduce a bug because (x & x) == (~0 & x).
>>
>> This bug can be avoided without changing the function's behaviour if the
>> return value of pcie_capability_read_dword is checked to confirm success.
>>
>> Check the return value of pcie_capability_read_dword() to ensure success.
>>
>> Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
>> Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
> Please check your setup, linux-wireless was not in Cc field.
>
Thank you for letting me know. I have fixed it and resent to the missing
addresses.
next prev parent reply other threads:[~2020-07-13 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 21:20 [PATCH 0/14 v3] PCI: Remove '*val = 0' from pcie_capability_read_*() Saheed Olayemi Bolarinwa
2020-07-10 21:20 ` [PATCH 14/14 " Saheed Olayemi Bolarinwa
[not found] ` <20200710212026.27136-5-refactormyself@gmail.com>
2020-07-13 13:44 ` [PATCH 4/14 v3] iwlegacy: Check the return value of pcie_capability_read_*() Kalle Valo
2020-07-13 18:02 ` Saheed Bolarinwa [this message]
[not found] <20200713175529.29715-1-refactormyself@gmail.com>
2020-07-13 17:55 ` Saheed O. Bolarinwa
2020-07-15 16:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa99aee8-86ee-558f-cb6f-761519c13159@gmail.com \
--to=refactormyself@gmail.com \
--cc=bjorn@helgaas.com \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).