RE: [PATCH 2/2] wifi: mac80211: improve station iteration ergonomics

[Ping-Ke Shih <pkshih@realtek.com>]

Hi Johannes,

> +/**
> + * for_each_station - iterate stations under wiphy mutex
> + * @sta: the iterator variable
> + * @hw: the HW to iterate for
> + */
> +#define for_each_station(sta, hw)                                      \
> +       for (sta = __ieee80211_iterate_stations(hw, NULL);              \
> +            sta;                                                       \
> +            sta = __ieee80211_iterate_stations(hw, sta))
> +

I'm going to use for_each_station() in rtw89 driver, and the code in driver side
looks very simple! Thanks for this new API.

However, without other callers rather than ieee80211_iterate_xxx(), I'd like
to know if it is expected that driver uses for_each_station()? Since help
text is added, I think it can be, right?

Another question is that adding ieee80211_ prefix would be consistent with
other API? If you agree, I can make patches.

As well as for_each_interface().

Ping-Ke