From: Johannes Berg <johannes@sipsolutions.net>
To: Lachlan Hodges <lachlan.hodges@morsemicro.com>,
meihaipeng <meihaipeng@uniontech.com>
Cc: Andrei Otcheretianski <andrei.otcheretianski@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+c0472dd80bb8f668625f@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: mac80211_hwsim: handle 5/10 MHz chanctx in rc update
Date: Fri, 29 May 2026 08:20:13 +0200 [thread overview]
Message-ID: <fc34f52ed88ee22b776828f06489a043316456a8.camel@sipsolutions.net> (raw)
In-Reply-To: <qrtsnjplvmg2pbq2cym5s3c5zxm5lrxw5dui26ks4jbbmmqhem@uwzblpmgdi5h> (sfid-20260529_071103_051144_2118964C)
On Fri, 2026-05-29 at 15:10 +1000, Lachlan Hodges wrote:
> Hi,
>
> > The STA bandwidth enum has no sub-20 MHz states, so a normal 20 MHz link
> > STA falsely trips the warning on 5/10 MHz OCB channel contexts.so
> > a normal 20 MHz link STA falsely trips the warning on 5/10 MHz OCB
> > channel contexts.
>
> There is also S1G widths :) but that doesn't really matter.
>
> > Treat sub-20 MHz channel contexts as 20 MHz for this validation and use
> > the actual channel-context width in the warning message.
> >
> > Fixes: aea9a6088ae46 ("wifi: mac80211_hwsim: do rc update per link")
> > Reported-by: syzbot+c0472dd80bb8f668625f@syzkaller.appspotmail.com
> > Closes: https://syzkaller.appspot.com/bug?extid=c0472dd80bb8f668625f
> > Signed-off-by: meihaipeng <meihaipeng@uniontech.com>
>
> Looking at the stack trace of this report and a few of the others,
> it comes from mac80211_hwsim_sta_add() which calls the rc_update on
> the new STA, so it would probably be better to do something similar
> to what we did for S1G [1] since I'm pretty sure the rc_update()
> path isn't reachable on 5/10MHz (just like S1G).
I don't know if it is or isn't, but a simpler change like that would
indeed seem preferable.
> Though there are also quite a few 5/10MHz syzbot reports for various
> things similar so maybe it's not worth it.. but that is up to
> Johannes :).
Yeah, I'm still going to rip it out entirely soon.
johannes
prev parent reply other threads:[~2026-05-29 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 4:09 [PATCH] wifi: mac80211_hwsim: handle 5/10 MHz chanctx in rc update meihaipeng
2026-05-29 5:10 ` Lachlan Hodges
2026-05-29 6:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc34f52ed88ee22b776828f06489a043316456a8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrei.otcheretianski@intel.com \
--cc=lachlan.hodges@morsemicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=meihaipeng@uniontech.com \
--cc=syzbot+c0472dd80bb8f668625f@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox