From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage
Date: Sun, 09 Aug 2020 20:32:57 -0700 [thread overview]
Message-ID: <fc6a6a11da040dbb85cb7c41201b2736@codeaurora.org> (raw)
In-Reply-To: <20200805153516.310cef625955.I0abc04dc8abb2c7c005c88ef8fa2d0e3c9fb95c4@changeid>
On 2020-08-05 06:35, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> In nl80211_set_station(), we check NL80211_ATTR_HE_6GHZ_CAPABILITY
> and then use NL80211_ATTR_HE_CAPABILITY, which is clearly wrong.
> Fix this to use NL80211_ATTR_HE_6GHZ_CAPABILITY as well.
>
> Fixes: 43e64bf301fd ("cfg80211: handle 6 GHz capability of new
> station")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> net/wireless/nl80211.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 19281d0c8c9d..bfda09d24146 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -6008,7 +6008,7 @@ static int nl80211_set_station(struct sk_buff
> *skb, struct genl_info *info)
>
> if (info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY])
> params.he_6ghz_capa =
> - nla_data(info->attrs[NL80211_ATTR_HE_CAPABILITY]);
> + nla_data(info->attrs[NL80211_ATTR_HE_6GHZ_CAPABILITY]);
>
Thanks for the fix :). Must have overlooked.
-Rajkumar
prev parent reply other threads:[~2020-08-10 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 13:35 [PATCH] nl80211: fix NL80211_ATTR_HE_6GHZ_CAPABILITY usage Johannes Berg
2020-08-10 3:32 ` Rajkumar Manoharan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc6a6a11da040dbb85cb7c41201b2736@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).