From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: Peter Oh <peter.oh@bowerswilkins.com>,
Anilkumar Kolli <akolli@codeaurora.org>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Sathishkumar Muruganandam <murugana@codeaurora.org>
Subject: Re: [PATCH 1/2] ath10k: Add WMI FWTEST command support
Date: Mon, 5 Mar 2018 20:31:33 +0100 [thread overview]
Message-ID: <fd392368-5535-d10e-b1bb-934e45fd9c43@dd-wrt.com> (raw)
In-Reply-To: <94f133b3-ee5d-6ed8-d7e8-20dff9aaede2@bowerswilkins.com>
Am 05.03.2018 um 19:48 schrieb Peter Oh:
> From: Sathishkumar Muruganandam <murugana@codeaurora.org>
>> This patch adds support for WMI_FWTEST_CMD.
>> This command is used for setting the wifi parameters.
>
> It's too lack of information in commit message.
> You should add such what values are acceptable for which purpose by
> each param_id and param_value to make this changes meaningful to
> community.
i agree. i reviewed the firmware sourcecode to find out what its doing,
but also within the firmware is almost undocumented. its a bunch of
undocumented
numeric parameters with undocumented behaviour.
if qca is willig to document this feature it might be included.
Sebastian
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565
next prev parent reply other threads:[~2018-03-05 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 6:59 [PATCH 0/2] FWTEST command support in debugfs Anilkumar Kolli
2018-03-05 6:59 ` [PATCH 1/2] ath10k: Add WMI FWTEST command support Anilkumar Kolli
2018-03-05 18:48 ` Peter Oh
2018-03-05 19:31 ` Sebastian Gottschall [this message]
2018-03-05 6:59 ` [PATCH 2/2] ath10k: add debugfs support to configure fwtest parameters Anilkumar Kolli
2018-03-05 7:42 ` Sven Eckelmann
2018-03-05 10:46 ` akolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd392368-5535-d10e-b1bb-934e45fd9c43@dd-wrt.com \
--to=s.gottschall@dd-wrt.com \
--cc=akolli@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=murugana@codeaurora.org \
--cc=peter.oh@bowerswilkins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).