From: Pkshih <pkshih@realtek.com>
To: "Íñigo Huguet" <ihuguet@redhat.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>
Subject: RE: [PATCH] rtw89: fix maybe uninitialized `qempty` variable
Date: Fri, 14 Jan 2022 01:07:32 +0000 [thread overview]
Message-ID: <fdee7063c0984c46bb374419fab606d2@realtek.com> (raw)
In-Reply-To: <20220113094253.73370-1-ihuguet@redhat.com>
> -----Original Message-----
> From: Íñigo Huguet <ihuguet@redhat.com>
> Sent: Thursday, January 13, 2022 5:43 PM
> To: linux-wireless@vger.kernel.org
> Cc: Pkshih <pkshih@realtek.com>; kvalo@kernel.org; Íñigo Huguet <ihuguet@redhat.com>
> Subject: [PATCH] rtw89: fix maybe uninitialized `qempty` variable
>
> Call to dle_dfi_qempty might fail, leaving qempty.qempty untouched, which
> is latter used to control the for loop. If that happens, it's not
> initialized anywhere.
>
> Initialize it so the loop doesn't iterate unless it's modified by the
> call to dle_dfi_qempty.
>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
[...]
next prev parent reply other threads:[~2022-01-14 1:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 9:42 [PATCH] rtw89: fix maybe uninitialized `qempty` variable Íñigo Huguet
2022-01-14 1:07 ` Pkshih [this message]
2022-01-28 15:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdee7063c0984c46bb374419fab606d2@realtek.com \
--to=pkshih@realtek.com \
--cc=ihuguet@redhat.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).