Re: [PATCH wireless-next] wifi: mac80211: Guard FILS discovery and unsolicited broadcast probe response

[Manish Dharanenthiran <manish.dharanenthiran@oss.qualcomm.com>]

On 9/4/2026 3:46 PM, Johannes Berg wrote:
> On Thu, 2026-08-20 at 21:37 +0530, Manish Dharanenthiran wrote:
>>
>> +++ b/net/mac80211/cfg.c
>> @@ -1138,7 +1138,7 @@ static int ieee80211_set_fils_discovery(struct ieee80211_sub_if_data *sdata,
>>   	struct fils_discovery_data *new, *old = NULL;
>>   	struct ieee80211_fils_discovery *fd;
>>   
>> -	if (!params->update)
>> +	if (!params->update || link_conf->nontransmitted)
>>   		return 0;
> 
> So why shouldn't we just reject it?
>   

Currently in user-space there is no restriction on sending this for 
non-transmitting BSS, thus it may send this for those BSSs as well, 
however the driver will use only for Tx BSS and ignore this config for 
Non-Tx BSS. Returning an error here could be fatal because failing 
start_ap or update_ap operation would result in failure of bringing up 
those BSSs.

We are working on the patch to update the behavior in hostap as well to 
not set this for Non-Tx BSS, but to maintain the backward compatibility, 
and the update from any other user-space application thus doesn't handle 
in a similar way, we ignored the update silently and kept as no-op.

Please let us know your thoughts.

>>   	fd = &link_conf->fils_discovery;
>> @@ -1173,7 +1173,7 @@ ieee80211_set_unsol_bcast_probe_resp(struct ieee80211_sub_if_data *sdata,
>>   {
>>   	struct unsol_bcast_probe_resp_data *new, *old = NULL;
>>   
>> -	if (!params->update)
>> +	if (!params->update || link_conf->nontransmitted)
>>   		return 0;
> 
> Same here.
> 
> johannes

-- 
- Manish D