From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA13C28CC3 for ; Fri, 7 Jun 2019 07:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31AF020657 for ; Fri, 7 Jun 2019 07:22:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="BcQFPhHf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbfFGHWX (ORCPT ); Fri, 7 Jun 2019 03:22:23 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39587 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfFGHWX (ORCPT ); Fri, 7 Jun 2019 03:22:23 -0400 Received: by mail-ed1-f66.google.com with SMTP id m10so1575302edv.6 for ; Fri, 07 Jun 2019 00:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WIWHcUlruIXuWb7Q4ynz/R9GRZd3PnDUIIzWnxLGnbU=; b=BcQFPhHfhwVZRgOVFwRt7Mkx1+kpvZItpmQh3BEcF5Wh8/aNgVD684++hWYf45IZUD K1pZ8g8NshAfFZi2WTU9qqRdOjeNl5xZlrIULYk62STnWAW1U9wcUlcdX0lIri2maVz6 o7nEWrowl89M+LYQtOD+G3wNpNuabb640WkrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WIWHcUlruIXuWb7Q4ynz/R9GRZd3PnDUIIzWnxLGnbU=; b=RMpD7u9fS9K6NY/CeaRMaZk4w7y8OOOOpmVUzf02qy2dEda72IzagoOL8xeFw3x+AM RyuQaQ9zpj9NhXIc01GDqZOW6riHRgPToGEsuaA5ta91YeDBViMIK4QznLYWHhe2wt60 ReGd6hqkqfDA8mw5QRd9e4T1wKZsg4tbipcMGmDoovJx8xHN9cnyXKyWqleRAYyn44No dj+ibMLf7UjFBGtYOwLN/Er7XOQ6W8yNGfXPpUe9jZYdwzN/HLP4j4DLTxyNlMj+ZON0 IxHgE4AGaolDOr8D1IzxkONZ5nKNcjD19h/bp3bgGhT2AlsxYTVhqaT7HS3AkXtj0nnd xS4g== X-Gm-Message-State: APjAAAVtTAgkQOzOSOG67gFUInPfnOD+wGwnG/qKcdubf+iUKgnwpCXp YCCS24jgVOO7IIqHeJQZovtOyA== X-Google-Smtp-Source: APXvYqxQj6rBH38LA9YI4caeohRUERNuFRwalQB5gWn5Haan4KavMiNH9q8K0T/T7+VJZ3s1ZAXl+A== X-Received: by 2002:a50:bdc5:: with SMTP id z5mr39004669edh.61.1559892141432; Fri, 07 Jun 2019 00:22:21 -0700 (PDT) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id c10sm302513edk.80.2019.06.07.00.22.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 00:22:20 -0700 (PDT) Subject: Re: [PATCH V2] iw: print HE capabilities To: Joe Perches , John Crispin , Johannes Berg Cc: linux-wireless@vger.kernel.org, Shashidhar Lakkavalli References: <20190528065828.25356-1-john@phrozen.org> From: Arend Van Spriel Message-ID: Date: Fri, 7 Jun 2019 09:22:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 6/7/2019 4:11 AM, Joe Perches wrote: > On Tue, 2019-05-28 at 08:58 +0200, John Crispin wrote: >> Print the HE MAC/PHY capabilities and MCS/NSS sets. > > trivia: > >> diff --git a/util.c b/util.c > [] >> +void print_he_info(struct nlattr *nl_iftype) >> +{ >> + struct nlattr *tb[NL80211_BAND_IFTYPE_ATTR_MAX + 1]; >> + struct nlattr *tb_flags[NL80211_IFTYPE_MAX + 1]; >> + char *iftypes[NUM_NL80211_IFTYPES] = { >> + "Unspec", "Adhoc", "Station", "AP", "AP/VLAN", "WDS", "Monitor", >> + "Mesh", "P2P/Client", "P2P/Go", "P2P/Device", "OCB", "NAN", >> + }; > > Should probably be > const char * const iftypes[...] We are doing this iftype string mapping in several places so a helper function may be warranted. Gr. AvS