From: Johannes Berg <johannes@sipsolutions.net>
To: Priyansha Tiwari <priyansha.tiwari@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, quic_drohan@quicinc.com
Subject: Re: [PATCH wireless-next v2 2/4] wifi: cfg80211/nl80211: rename to probe_peer(), extend probe status, and update in-tree users
Date: Tue, 05 May 2026 14:39:26 +0200 [thread overview]
Message-ID: <ffd01c8f9621bdb561e8d39a7c33296fa9bcb2db.camel@sipsolutions.net> (raw)
In-Reply-To: <20260417133124.3412752-3-pritiwa@qti.qualcomm.com>
Your subject lines are way too long, you really don't need to spell out
everything, and if there's a list of things, probably better to break
into multiple patches.
> Update in-tree users (wil6210, mwifiex) and mac80211 so the tree continues
> to build after this change.
That's also pretty obvious.
> mac80211 switches cfg80211_ops to .probe_peer and passes link_id = -1
> at the probe status callsite to preserve existing behavior.
>
> This change is otherwise behavior-neutral, per-link STA reporting will
> follow in a subsequent patch.
I think you really should split this differently - perhaps first an
internal API change, that just does all the renaming, then the actual
logic change including the nl80211 API, and finally the mac80211
implementation?
johannes
next prev parent reply other threads:[~2026-05-05 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 13:31 [PATCH wireless-next v2 0/4] wifi: nl80211: introduce PROBE_PEER for AP and STA with MLO support Priyansha Tiwari
2026-04-17 13:31 ` [PATCH wireless-next v2 1/4] wifi: nl80211: rename PROBE_CLIENT to PROBE_PEER and add STA-side probing support Priyansha Tiwari
2026-05-05 12:37 ` Johannes Berg
2026-04-17 13:31 ` [PATCH wireless-next v2 2/4] wifi: cfg80211/nl80211: rename to probe_peer(), extend probe status, and update in-tree users Priyansha Tiwari
2026-05-05 12:39 ` Johannes Berg [this message]
2026-04-17 13:31 ` [PATCH wireless-next v2 3/4] wifi: mac80211: add per-link PROBE_PEER support Priyansha Tiwari
2026-05-05 12:44 ` Johannes Berg
2026-04-17 13:31 ` [PATCH wireless-next v2 4/4] wifi: mac80211_hwsim: report TX status link_id Priyansha Tiwari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd01c8f9621bdb561e8d39a7c33296fa9bcb2db.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=priyansha.tiwari@oss.qualcomm.com \
--cc=quic_drohan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox