linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Haggett <podge@podgeweb.com>
To: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc4] mac80211: don't send empty extended rates IE
Date: Tue, 16 Sep 2008 10:33:54 +0930	[thread overview]
Message-ID: <gan0ln$ikd$1@ger.gmane.org> (raw)
In-Reply-To: 200808251832.m7PIW6kA071701@enterprise.localnet.radiotube.org

Jan-Espen Pettersen wrote:

> The association request includes a list of supported data rates.
> 
> 802.11b: 4 supported rates.
> 802.11g: 12 (8 + 4) supported rates.
> 802.11a: 8 supported rates.
> 
> The rates tag of the assoc request has room for only 8 rates. In case of
> 802.11g an extended rate tag is appended. However in net/wireless/mlme.c
> an extended (empty) rate tag is also appended if the number of rates is
> exact 8. This empty (length=0) extended rates tag causes some APs to
> deny association with code 18 (unsupported rates). These APs include my
> ZyXEL G-570U, and according to Tomas Winkler som Cisco APs.
> 
> 'If count == 8' has been used to check for the need for an extended rates
> tag. But count would also be equal to 8 if the for loop exited because of
> no more supported rates. Therefore a check for count being less than
> rates_len would seem more correct.
> 
> Thanks to:
>  * Dan Williams for newbie guidance
>  * Tomas Winkler for confirming the problem
> 
> Signed-off-by: Jan-Espen Pettersen

Just to add to this. I've had a long standing issue with my laptop not
associating to my AP at home and this patch has fixed my issue as well. My
AP however is a Billion 7404VGO-M ADSL modem/router/802.11b/g and my
wireless card an Intel Wireless 4965AGN chipset.

Previous behaviour was the card would associate, then drop out, then
associate again... over and over. Never any traffic, but would work fine on
other APs. I applied this patch to my 2.6.26 kernel and now it works fine.

Thanks!


      reply	other threads:[~2008-09-16  1:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25 18:29 [PATCH 2.6.27-rc4] mac80211: don't send empty extended rates IE Jan-Espen Pettersen
2008-09-16  1:03 ` Shawn Haggett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gan0ln$ikd$1@ger.gmane.org' \
    --to=podge@podgeweb.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).