From: Dirk Gouders <dirk@gouders.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
linux-wireless@vger.kernel.org,
Mathias Kretschmer <mathias.kretschmer@fokus.fraunhofer.de>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3.12] cfg80211: fix ibss wext chandef creation
Date: Mon, 28 Oct 2013 18:05:26 +0100 [thread overview]
Message-ID: <ghhac1l415.fsf@lena.gouders.net> (raw)
In-Reply-To: <1382970069.17956.23.camel@jlt4.sipsolutions.net> (Johannes Berg's message of "Mon, 28 Oct 2013 15:21:09 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2013-10-22 at 22:02 +0200, Simon Wunderlich wrote:
>> The wext internal chandefs for ibss should be created using the
>> cfg80211_chandef_create() functions. Otherwise the center_freq1 field
>> will not be set and cfg80211_chandef_valid() will spit a warning and
>> report the chandef as invalid when it should be used.
>
> I think
>
> commit f478f33a93f9353dcd1fe55445343d76b1c3f84a
> Author: Bruno Randolf <br1@einfach.org>
> Date: Thu Sep 26 16:55:28 2013 +0100
>
> cfg80211: fix warning when using WEXT for IBSS
>
>
> already fixed this. Your patch doesn't apply, but feel free to send me a
> new one (for -next) converting to the creation helpers.
I tested the above commit and it also fixes the problems I noticed here.
Dirk
next prev parent reply other threads:[~2013-10-28 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 20:02 [PATCH 3.12] cfg80211: fix ibss wext chandef creation Simon Wunderlich
2013-10-23 5:46 ` Dirk Gouders
2013-10-28 14:21 ` Johannes Berg
2013-10-28 17:05 ` Dirk Gouders [this message]
2013-10-28 17:14 ` Dirk Gouders
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ghhac1l415.fsf@lena.gouders.net \
--to=dirk@gouders.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mathias.kretschmer@fokus.fraunhofer.de \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox