linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@suse.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ron Rindjunsky <ron.rindjunsky@intel.com>,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	flamingice@sourmilk.net, tomas.winkler@intel.com
Subject: Re: [PATCH 04/15] mac80211: adding 802.11n IEs handling
Date: Mon, 26 Nov 2007 19:00:21 +0100	[thread overview]
Message-ID: <jeabp028ga.fsf@sykes.suse.de> (raw)
In-Reply-To: <1196096412.4149.311.camel@johannes.berg> (Johannes Berg's message of "Mon\, 26 Nov 2007 18\:00\:12 +0100")

Johannes Berg <johannes@sipsolutions.net> writes:

>> > On Mon, 2007-11-26 at 16:14 +0200, Ron Rindjunsky wrote:
>> >> diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_=
i.h
>> >> index 9e5b3a9..9caf124 100644
>> >> --- a/net/mac80211/ieee80211_i.h
>> >> +++ b/net/mac80211/ieee80211_i.h
>> >> @@ -89,6 +89,8 @@ struct ieee80211_sta_bss {
>> >>  	size_t rsn_ie_len;
>> >>  	u8 *wmm_ie;
>> >>  	size_t wmm_ie_len;
>> >> +	u8 *ht_ie;
>> >> +	size_t ht_ie_len;
>> >
>> > At some point we probably should reorder the fields here to avoid =
all
>> > the padding... Not in this patch though, of course.
>>=20
>> There should not be any padding, size_t has the same size as a point=
er.
>
> Even on 64-bit? In any case, the _len vars can all be u8 too.

I think you are missing a couple of '*'s here.

Andreas.

--=20
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstra=DFe 5, 90409 N=FCrnberg, Germany
PGP key fingerprint =3D 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4=
ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-11-26 18:00 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-26 14:14 [PATCH 0/15] mac80211/iwlwifi (#everything): integrate IEEE802.11n support Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 01/15] mac80211: adding MAC80211_HT_DEBUG config variable Ron Rindjunsky
2007-11-26 16:26   ` Johannes Berg
2007-11-26 14:14 ` [PATCH 02/15] mac80211: adding 802.11n definitions in ieee80211.h Ron Rindjunsky
2007-11-26 16:27   ` Johannes Berg
2007-11-26 14:14 ` [PATCH 03/15] mac80211: adding 802.11n HT framework definitions Ron Rindjunsky
2007-11-26 16:28   ` Johannes Berg
2007-11-26 14:14 ` [PATCH 04/15] mac80211: adding 802.11n IEs handling Ron Rindjunsky
2007-11-26 16:29   ` Johannes Berg
2007-11-26 16:57     ` Andreas Schwab
2007-11-26 17:00       ` Johannes Berg
2007-11-26 18:00         ` Andreas Schwab [this message]
2007-11-27 13:08           ` Johannes Berg
2007-11-26 14:14 ` [PATCH 05/15] mac80211: adding 802.11n essential A-MPDU addBA capability Ron Rindjunsky
2007-11-26 16:31   ` Johannes Berg
2007-11-27  9:27     ` Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 06/15] mac80211: adding 802.11n essential A-MSDU Rx capability Ron Rindjunsky
2007-11-26 16:35   ` Johannes Berg
2007-11-26 17:25     ` Tomas Winkler
2007-11-26 18:40   ` Michael Wu
2007-11-27  9:48     ` Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 07/15] mac80211: adding 802.11n configuration flows Ron Rindjunsky
2007-11-26 16:36   ` Johannes Berg
2007-11-27  9:34     ` Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 08/15] iwlwifi: 802.11n remove unnecessary config dependency Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 09/15] iwlwifi: 802.11n new framework structures preperation Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 10/15] iwlwifi: 802.11n configuring hw_mode parameters to support HT in A/G Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 11/15] iwlwifi: 802.11n handling probe request HT IE Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 12/15] iwlwifi: 802.11n comply HT self configuration flow with mac80211 framework Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 13/15] iwlwifi: 802.11n comply HT add station " Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 14/15] iwlwifi: 802.11n comply HT rate scaling flows " Ron Rindjunsky
2007-11-26 14:14 ` [PATCH 15/15] iwlwifi: 802.11n add support to 8K A-MSDU Rx frames Ron Rindjunsky
2007-11-26 16:26   ` Johannes Berg
2007-11-26 17:15     ` Tomas Winkler
2007-11-27  1:34 ` [PATCH 0/15] mac80211/iwlwifi (#everything): integrate IEEE802.11n support Luis R. Rodriguez
2007-11-27  9:12   ` Ron Rindjunsky
  -- strict thread matches above, loose matches on Subject: below --
2007-11-14 15:29 Ron Rindjunsky
2007-11-14 15:29 ` [PATCH 04/15] mac80211: adding 802.11n IEs handling Ron Rindjunsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jeabp028ga.fsf@sykes.suse.de \
    --to=schwab@suse.de \
    --cc=flamingice@sourmilk.net \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=ron.rindjunsky@intel.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).